Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 1, 2021. It is now read-only.

Conversation

@jemshit
Copy link

@jemshit jemshit commented Feb 22, 2016

Click event to center of list item still occurs sometimes even user clicks to corner of item. This removes double ripple effect when that occurs. Tested on android 4.1.2 , 4.4 , 5.0 , 6.0

…st items. But still click event to corner of any list item occurs on the center of item sometimes.
@AndroidDeveloperLB
Copy link
Owner

You mean you fixed this issue:
#19
?
I've tested it, and it shows a ripple in the center. I don't understand in which cases.
I'm not sure if I prefer it with this bug or the other one. :(

@jemshit
Copy link
Author

jemshit commented Feb 22, 2016

Yes, but there is still that weird click event even ripple effect looks correct. Try clicking to corner of first preference item on sample.

@jemshit
Copy link
Author

jemshit commented Feb 22, 2016

And this doesn't add ripple for 2.x

@AndroidDeveloperLB
Copy link
Owner

What is the "weird click event" ? If it changes the behavior and not just
how it looks, please tell me.

About 2.x , I didn't mean it does. I was hoping you'd know how to make it
look at least like on ICS

On Mon, Feb 22, 2016 at 3:11 PM, Jemshit Iskenderov <
notifications@github.com> wrote:

And this doesn't add ripple for 2.x


Reply to this email directly or view it on GitHub
#21 (comment)
.

@jemshit
Copy link
Author

jemshit commented Feb 22, 2016

Old sample demo video: http://sendvid.com/seggqpof
New demo: http://sendvid.com/08lju6xz

@AndroidDeveloperLB
Copy link
Owner

yes, this is what I saw.
It's better than before, but it's not quite a fix, as it can show middle
ripple on some cases.
:(

On Mon, Feb 22, 2016 at 4:55 PM, Jemshit Iskenderov <
notifications@github.com> wrote:

Old sample demo video: http://sendvid.com/seggqpof
New demo: http://sendvid.com/08lju6xz


Reply to this email directly or view it on GitHub
#21 (comment)
.

AndroidDeveloperLB added a commit that referenced this pull request Feb 25, 2016
Almost fixed ripple effect issue on android 6 when pressing preferences items. See this: #19
Also, for some reason, now it sometimes show the ripple in the middle.
@AndroidDeveloperLB AndroidDeveloperLB merged commit a3ef8e8 into AndroidDeveloperLB:master Feb 25, 2016
@AndroidDeveloperLB
Copy link
Owner

Question:
why for "mpl__custom_ripple_effect_background.xml" inside "drawable", you made all states show transparent color, instead of just a single item that show transparent (first one) ?

@AndroidDeveloperLB
Copy link
Owner

anyway, fixed this issue on version 7.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.