Homework#62
Open
aksenovasmail-git wants to merge 1 commit intoAndroid-Developer-Basic:masterAndroid-Developer-Basic/View-Resources:masterfrom
Open
Homework#62aksenovasmail-git wants to merge 1 commit intoAndroid-Developer-Basic:masterAndroid-Developer-Basic/View-Resources:masterfrom
aksenovasmail-git wants to merge 1 commit intoAndroid-Developer-Basic:masterAndroid-Developer-Basic/View-Resources:masterfrom
Conversation
|
|
||
| <item name="colorOnSurface">#C4C6CF</item> | ||
| <item name="colorOnBackground">#C4C6CF</item> | ||
| <color name="login_toolbar_content">#C4C6CF</color> |
There was a problem hiding this comment.
Внутри style можно использовать только item для определения атрибутов темы
Тег color допустим только в файлах типа colors.xml. Это вызывает ошибку компиляции: "Can not extract resource from ParsedResource"
| import otus.gpb.homework.viewandresources.databinding.ItemCartBinding | ||
| import otus.gpb.homework.viewandresources.model.CartItem | ||
|
|
||
| data class CartItem( |
There was a problem hiding this comment.
Дублируется data class CartItem, хотя он уже определен в model/CartItem.kt и импортирован
| <item name="android:textColor">?attr/colorOnSurface</item> | ||
| <item name="android:textSize">20sp</item> | ||
| <item name="android:textStyle">normal</item> | ||
| <item name="android:textColor">?attr/colorOnBackground</item> |
There was a problem hiding this comment.
Дважды указан android:textColor. Последний перезаписывает первый, поэтому применяется только ?attr/colorOnBackground. Удалите один из них, оставив нужный по макету.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.