Сделал ДЗ № 15#8
Open
anv0l wants to merge 5 commits intoAndroid-Developer-Basic:masterAndroid-Developer-Basic/CoroutinesHomework:masterfrom
Open
Сделал ДЗ № 15#8anv0l wants to merge 5 commits intoAndroid-Developer-Basic:masterAndroid-Developer-Basic/CoroutinesHomework:masterfrom
anv0l wants to merge 5 commits intoAndroid-Developer-Basic:masterAndroid-Developer-Basic/CoroutinesHomework:masterfrom
Conversation
Не понятно, зачем нужно repeatOnLifecycle или я что-то не так сделал.
| viewModelScope.launch(Dispatchers.IO) { | ||
| LoginApi().logout() | ||
| } | ||
| _state.value = LoginViewState.Login() |
There was a problem hiding this comment.
Обратите внимание, что у вас состояние экрана меняется синхронно, а логаут выполняется асинхронно. Соответственно, состояние экрана не соответствует реальному состоянию системы. Логаут может занять несколько секунд и вернуть ошибку, например
| fun login(name: String, password: String) { | ||
| // TODO: Implement login | ||
| _state.value = LoginViewState.LoggingIn | ||
| viewModelScope.launch(Dispatchers.IO) { |
There was a problem hiding this comment.
Мне кажется, удобнее было бы сделать так:
viewModelScope.launch {
runCatching {
// Переходим на другой контекст
withContext(Dispatchers.IO) { LoginApi().login(...) }.fold (
{
// Здесь мы снова в изначальном контексте
_state.value = _state.value = LoginViewState.Content(it)
},
{ _state.value = LoginViewState.Login(error = it) }
)
}
}Помните, что контекст корутины восстанавливается на основной после вызова withContext. И запускать корутину для обновления состояния экрана - не нужно
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.