Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added the lucky numbers algorithm #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Added the lucky numbers algorithm #53

merged 1 commit into from
Oct 1, 2019

Conversation

MrGrote
Copy link
Contributor

@MrGrote MrGrote commented Oct 10, 2018

Adds an implementation of an algorithm to generate the lucky numbers sequence.

#40

Copy link
Collaborator

@christianbender christianbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work! I have a request


return sequence

print(generate_lucky_number_sequence(int(input("Please enter the upper bound of the lucky number sequence: "))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a main-function with some test cases

while len(sequence) > sequence[n]:
number_to_delete = sequence[n]
del sequence[number_to_delete-1::number_to_delete]
n = n + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use +=

Copy link
Member

@abranhe abranhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution to The All ▲lgorithms Project. Without people like you submitting Pull Requests we couldn't run this project. You rock @MrGrote

@abranhe abranhe merged commit 6d2ad66 into AllAlgorithms:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.