Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

[OGUI-1847] Fix arrays saved as objects and other small fixes#3236

Open
Deaponn wants to merge 5 commits intodevAliceO2Group/WebUi:devfrom
fix/CNF/OGUI-1847/arrays-saved-as-objectsAliceO2Group/WebUi:fix/CNF/OGUI-1847/arrays-saved-as-objectsCopy head branch name to clipboard
Open

[OGUI-1847] Fix arrays saved as objects and other small fixes#3236
Deaponn wants to merge 5 commits intodevAliceO2Group/WebUi:devfrom
fix/CNF/OGUI-1847/arrays-saved-as-objectsAliceO2Group/WebUi:fix/CNF/OGUI-1847/arrays-saved-as-objectsCopy head branch name to clipboard

Conversation

@Deaponn
Copy link
Collaborator

@Deaponn Deaponn commented Dec 15, 2025

This PR fixes a couple of bugs:

  • one where arrays are converted into objects on configuration save ([true, 'text', 99] becomes { 0: true, 1: 'text', 2: 99 })
  • one where edit difference highlighting fails for FormToggleInput component
  • one where empty objects and lists are not parsed correctly which causes them to be lost while saving

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue "Status" is set to "In review"
  • PR labels are selected

Copy link
Collaborator

@piechnikk piechnikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.