Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Migration of MCReplayEngine to vmc v2.0#30

Merged
benedikt-voelkel merged 4 commits intoAliceO2Group:masterAliceO2Group/VMCStepLogger:masterfrom
ihrivnac:vmc-2-0-migrationihrivnac/VMCStepLogger:vmc-2-0-migrationCopy head branch name to clipboard
Feb 24, 2022
Merged

Migration of MCReplayEngine to vmc v2.0#30
benedikt-voelkel merged 4 commits intoAliceO2Group:masterAliceO2Group/VMCStepLogger:masterfrom
ihrivnac:vmc-2-0-migrationihrivnac/VMCStepLogger:vmc-2-0-migrationCopy head branch name to clipboard

Conversation

@ihrivnac
Copy link
Contributor

The MCReplayEngine class is updated for the changes in TVirtualMC interface in the new vmc version

@ihrivnac
Copy link
Contributor Author

@sawenzel , @benedikt-voelkel , could you, please, merge? Thank you.

@benedikt-voelkel
Copy link
Contributor

Thanks @ihrivnac I will test it later to merge it.
Also, I will then release a new tag and let you know so we can take care of that in the alidist recipe as well

@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Feb 24, 2022

It builds just fine @ihrivnac
I am testing now with current G4_VMC@v6.0 and G4@v11.0

@benedikt-voelkel
Copy link
Contributor

Actually, that doesn't seem to be straightforward. I have updated everything including VGM and GEANT3. However, now I have problems to build FairRoot.
Did you check the full build chain with the newest VMC packages and O2? If so, which ROOT, FairRoot did you use?

@benedikt-voelkel
Copy link
Contributor

Tested with FairRoot@master. Logging and replay works as expected

@benedikt-voelkel benedikt-voelkel merged commit 951505c into AliceO2Group:master Feb 24, 2022
@ihrivnac
Copy link
Contributor Author

Actually, that doesn't seem to be straightforward. I have updated everything including VGM and GEANT3. However, now I have problems to build FairRoot. Did you check the full build chain with the newest VMC packages and O2? If so, which ROOT, FairRoot did you use?

Yes, I tested with new vmc packages tags:

  • vmc 2.0, geant3 4.0, geant4_vmc 6.0 - dev package
  • vgm - 5.0 - modified recipe
  • geant4 11.0 - dev package
  • root - not modified recipe
  • FairRoot - v18.4.1 - dev package

I did not get compilation error due to switch to vmc 2.0,; I will check with v18.4.2, which is actually in alidist.

For the time being, there is no geant4_vmc version compatible with vmc 2.0 and geant4 10.7.px.

@benedikt-voelkel
Copy link
Contributor

So the new tag v0.5.0 contains your changes @ihrivnac

@ihrivnac
Copy link
Contributor Author

So the new tag v0.5.0 contains your changes @ihrivnac

Yes, thanks. It compiles fine with the versions above; I updated also FairRoot to v18.4.2, which is the version in alidist; it requires a patch (as well as v18.4.1) in cmake/modules/FindROOT.cmake (adding EGPythia6 in _root_dep); this may be the reason why you had to update to newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.