Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

Tests cleanup & App class refactor#99

Merged
xsalonx merged 18 commits intomasterAliceO2Group/RunConditionTable:masterfrom
testingAliceO2Group/RunConditionTable:testingCopy head branch name to clipboard
Jun 9, 2023
Merged

Tests cleanup & App class refactor#99
xsalonx merged 18 commits intomasterAliceO2Group/RunConditionTable:masterfrom
testingAliceO2Group/RunConditionTable:testingCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Jun 6, 2023

@xsalonx nie dość, że nasze pokrycie testami jest mizerne, to jeszcze nawet od jakiegoś czasu wcale ich nie odpalamy... czas to zmienić 🖌️

  • moved HttpServer to the separate class WebUiServer
  • made modules return new istances of the classes (no new ...() invoke needed)
  • divided the app into actual modules

@Ehevi Ehevi changed the base branch from master to ui-improvement June 6, 2023 11:45
Base automatically changed from ui-improvement to master June 8, 2023 20:43
@Ehevi Ehevi changed the title Testing Tests cleanup & App class refactor Jun 9, 2023
@Ehevi Ehevi marked this pull request as ready for review June 9, 2023 09:14
@Ehevi Ehevi requested a review from xsalonx June 9, 2023 09:14
@xsalonx xsalonx merged commit 7b7a480 into master Jun 9, 2023
@xsalonx xsalonx deleted the testing branch June 9, 2023 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.