Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

Bug/incorrect page state while waiting for periods view data, cleanup#240

Merged
xsalonx merged 5 commits intomasterAliceO2Group/RunConditionTable:masterfrom
bug/incorrect-page-state-while-waiting-for-periods-and-cleanupAliceO2Group/RunConditionTable:bug/incorrect-page-state-while-waiting-for-periods-and-cleanupCopy head branch name to clipboard
Oct 5, 2023
Merged

Bug/incorrect page state while waiting for periods view data, cleanup#240
xsalonx merged 5 commits intomasterAliceO2Group/RunConditionTable:masterfrom
bug/incorrect-page-state-while-waiting-for-periods-and-cleanupAliceO2Group/RunConditionTable:bug/incorrect-page-state-while-waiting-for-periods-and-cleanupCopy head branch name to clipboard

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Oct 4, 2023

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

Notable changes for users:

  • stop showing Unknown Error page, while periods data are being loaded

Notable changes for developers:

  • remove one code duplication

Changes made to the database:

  • NA

@xsalonx xsalonx requested a review from martinboulais October 4, 2023 14:31
@xsalonx xsalonx marked this pull request as ready for review October 4, 2023 14:32
@xsalonx xsalonx self-assigned this Oct 4, 2023
@xsalonx xsalonx added bug Something isn't working frontend refactor labels Oct 4, 2023
@xsalonx xsalonx changed the title Bug/incorrect page state while waiting for periods and cleanup Bug/incorrect page state while waiting for period, cleanup Oct 4, 2023
@xsalonx xsalonx changed the title Bug/incorrect page state while waiting for period, cleanup Bug/incorrect page state while waiting for periods view, cleanup Oct 4, 2023
@xsalonx xsalonx changed the title Bug/incorrect page state while waiting for periods view, cleanup Bug/incorrect page state while waiting for periods view data, cleanup Oct 4, 2023
@xsalonx xsalonx force-pushed the bug/incorrect-page-state-while-waiting-for-periods-and-cleanup branch from 93d36df to 08c8029 Compare October 4, 2023 14:45
@xsalonx xsalonx merged commit 360c566 into master Oct 5, 2023
@xsalonx xsalonx deleted the bug/incorrect-page-state-while-waiting-for-periods-and-cleanup branch October 5, 2023 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working frontend refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.