Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-190] adjust db table#231

Merged
Ehevi merged 12 commits intomasterAliceO2Group/RunConditionTable:masterfrom
migration/ORCT-190/adjust-db-tableAliceO2Group/RunConditionTable:migration/ORCT-190/adjust-db-tableCopy head branch name to clipboard
Sep 28, 2023
Merged

[ORCT-190] adjust db table#231
Ehevi merged 12 commits intomasterAliceO2Group/RunConditionTable:masterfrom
migration/ORCT-190/adjust-db-tableAliceO2Group/RunConditionTable:migration/ORCT-190/adjust-db-tableCopy head branch name to clipboard

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Sep 27, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • time based and run based flags are managed the same way:
    • remove endpoint path part time-based
    • flag entity has attribute entire, which means run based flags if true, time based otherwise
    • flag creation endpoint requires it as query parameter

Notable changes for developers:

  • add flag types: Good, Bad and Mixed
  • add missing option to defined comment in qc flag creation api
  • introduce more reasoned solution for acquiring username for addedBy field in qc flags
  • remove unnecessary transactions

Changes made to the database:

  • fix bug - unfounded usage of flag allowNull: false causing failure of quality flag types insertion
  • time based and run based flags are managed the same way:
    • add field entire to flag table

@xsalonx xsalonx self-assigned this Sep 27, 2023
@xsalonx xsalonx requested a review from Ehevi September 27, 2023 16:03
@xsalonx xsalonx added the DB label Sep 28, 2023
@xsalonx xsalonx marked this pull request as ready for review September 28, 2023 07:28
app/lib/server/controllers/qualityControl.controller.js Outdated Show resolved Hide resolved
@Ehevi Ehevi merged commit 5ea8996 into master Sep 28, 2023
@Ehevi Ehevi deleted the migration/ORCT-190/adjust-db-table branch September 28, 2023 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.