Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

[ORCT-118] monalisa service mc test#221

Merged
Ehevi merged 13 commits intomasterAliceO2Group/RunConditionTable:masterfrom
test/ORCT-118/MonalisaServiceMC-testAliceO2Group/RunConditionTable:test/ORCT-118/MonalisaServiceMC-testCopy head branch name to clipboard
Sep 21, 2023
Merged

[ORCT-118] monalisa service mc test#221
Ehevi merged 13 commits intomasterAliceO2Group/RunConditionTable:masterfrom
test/ORCT-118/MonalisaServiceMC-testAliceO2Group/RunConditionTable:test/ORCT-118/MonalisaServiceMC-testCopy head branch name to clipboard

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Sep 19, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • introduce more exhaustive tests for MonalisaServiceMC
  • fixed spotted bug - periods were inserted without year and beamType in services
  • split big dbAction in MonalisaServiceMC to a few smaller methods

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Sep 19, 2023
@xsalonx xsalonx requested a review from Ehevi September 20, 2023 08:35
@xsalonx xsalonx marked this pull request as ready for review September 20, 2023 08:36
Ehevi
Ehevi reviewed Sep 21, 2023
View reviewed changes
test/lib/alimonitor-services/syncManager.test.js Outdated Show resolved Hide resolved
@Ehevi Ehevi merged commit 0fae798 into master Sep 21, 2023
@Ehevi Ehevi deleted the test/ORCT-118/MonalisaServiceMC-test branch September 21, 2023 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Ehevi Ehevi Ehevi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xsalonx xsalonx

Labels

backend CI javascript refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xsalonx @Ehevi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.