Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-165] Data action buttons#209

Merged
xsalonx merged 43 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-165/data-action-buttonsAliceO2Group/RunConditionTable:feature/ORCT-165/data-action-buttonsCopy head branch name to clipboard
Sep 22, 2023
Merged

[ORCT-165] Data action buttons#209
xsalonx merged 43 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-165/data-action-buttonsAliceO2Group/RunConditionTable:feature/ORCT-165/data-action-buttonsCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Sep 6, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • hide/show button works with the periods view

Notable changes for developers:

  • mark the previous hide functionality (using the deprecated dataAccessModel) as obsolete

Changes made to the database:

@Ehevi Ehevi self-assigned this Sep 6, 2023
@Ehevi Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch 2 times, most recently from 792d6e8 to bdc8aba Compare September 14, 2023 13:49
@Ehevi Ehevi marked this pull request as ready for review September 14, 2023 13:57
@Ehevi Ehevi requested a review from xsalonx September 14, 2023 13:58
@Ehevi Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch from fd2d189 to 46c50b2 Compare September 14, 2023 15:00
xsalonx
xsalonx suggested changes Sep 15, 2023
View reviewed changes
app/public/components/filter/filteringPanel.js Show resolved Hide resolved
app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved
app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved
xsalonx
xsalonx suggested changes Sep 15, 2023
View reviewed changes
app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved
app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved
xsalonx
xsalonx suggested changes Sep 15, 2023
View reviewed changes
app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved
xsalonx
xsalonx suggested changes Sep 15, 2023
View reviewed changes
app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved
xsalonx
xsalonx reviewed Sep 15, 2023
View reviewed changes
app/public/utils/filtering/filterUtils.js Outdated Show resolved Hide resolved
xsalonx
xsalonx suggested changes Sep 15, 2023
View reviewed changes
app/public/views/periods/PeriodsModel.js Outdated Show resolved Hide resolved
@Ehevi Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch from 46c50b2 to 9cdd76f Compare September 22, 2023 07:58
@Ehevi Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch from ca0b01d to 1132b72 Compare September 22, 2023 09:18
@Ehevi Ehevi requested a review from xsalonx September 22, 2023 09:45
xsalonx
xsalonx suggested changes Sep 22, 2023
View reviewed changes
app/public/components/filter/filteringPanel.js Outdated Show resolved Hide resolved
app/public/components/filter/filteringPanel.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx September 22, 2023 11:00
@xsalonx xsalonx merged commit 7d0693e into master Sep 22, 2023
@xsalonx xsalonx deleted the feature/ORCT-165/data-action-buttons branch September 22, 2023 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xsalonx xsalonx xsalonx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ehevi Ehevi

Labels

frontend refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ehevi @xsalonx
Morty Proxy This is a proxified and sanitized view of the page, visit original site.