Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-154] Active fields for the periods view#207

Merged
xsalonx merged 13 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-154/active-fieldsAliceO2Group/RunConditionTable:feature/ORCT-154/active-fieldsCopy head branch name to clipboard
Sep 5, 2023
Merged

[ORCT-154] Active fields for the periods view#207
xsalonx merged 13 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-154/active-fieldsAliceO2Group/RunConditionTable:feature/ORCT-154/active-fieldsCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Sep 5, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • add OverviewModel interface
  • docs cleanup
  • move navigation up in the model hierarchy, mark the previous one @deprecated
  • introduce href builder
  • remove the dependency of periods view on dataAccessModel

@Ehevi Ehevi self-assigned this Sep 5, 2023
@Ehevi Ehevi requested a review from xsalonx September 5, 2023 11:49
@Ehevi Ehevi marked this pull request as ready for review September 5, 2023 11:49
xsalonx
xsalonx suggested changes Sep 5, 2023
View reviewed changes
app/public/utils/url/urlUtils.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx September 5, 2023 12:36
@xsalonx xsalonx merged commit 3bfbcac into master Sep 5, 2023
@xsalonx xsalonx deleted the feature/ORCT-154/active-fields branch September 5, 2023 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xsalonx xsalonx xsalonx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ehevi Ehevi

Labels

frontend refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ehevi @xsalonx
Morty Proxy This is a proxified and sanitized view of the page, visit original site.