Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-143] - throw out pgmodeler design#172

Merged
Ehevi merged 21 commits intomasterAliceO2Group/RunConditionTable:masterfrom
improvement/ORCT-143/throw-out-pgmodeler-designAliceO2Group/RunConditionTable:improvement/ORCT-143/throw-out-pgmodeler-designCopy head branch name to clipboard
Aug 17, 2023
Merged

[ORCT-143] - throw out pgmodeler design#172
Ehevi merged 21 commits intomasterAliceO2Group/RunConditionTable:masterfrom
improvement/ORCT-143/throw-out-pgmodeler-designAliceO2Group/RunConditionTable:improvement/ORCT-143/throw-out-pgmodeler-designCopy head branch name to clipboard

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Aug 16, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • hooks for pgmodeler design outdated, please reinstall hooks
  • removed task db:export from rctmake

Changes made to the database:

  • use sequelize migration instead of sql file

  • setup-db.sh does not create tables anymore, only database, user with sufficient permissions

  • add sequelize model Meta and ParticlesPhysData

  • update Run model:

    • add field fillNumber
    • add field runType
  • delete columns from schema:

    • simulation_passes..ml
    • data_passes.jira
    • data_passes.ml
    • data_passes.software_version
    • runs.ir
    • runs.filling_scheme
    • runs.mu

@xsalonx xsalonx requested a review from Ehevi August 16, 2023 13:52
@xsalonx xsalonx self-assigned this Aug 16, 2023
@Ehevi Ehevi self-requested a review August 17, 2023 06:04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to still keep the database schema picture for the reference. I'd propose the docs folder for that purpose.

@Ehevi Ehevi merged commit fd2e314 into master Aug 17, 2023
@Ehevi Ehevi deleted the improvement/ORCT-143/throw-out-pgmodeler-design branch August 17, 2023 06:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.