Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-144] Update periods API#168

Merged
xsalonx merged 82 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-144/new-api-periodsAliceO2Group/RunConditionTable:feature/ORCT-144/new-api-periodsCopy head branch name to clipboard
Aug 28, 2023
Merged

[ORCT-144] Update periods API#168
xsalonx merged 82 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-144/new-api-periodsAliceO2Group/RunConditionTable:feature/ORCT-144/new-api-periodsCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Aug 15, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • add year field to the periods view
  • add a list of distinct run energies to the period view

Notable changes for developers:

  • use the new API endpoint for the periods view
  • rename pager to obsoletePager -> from now please use the new pager only
  • move userPreferences up in the model hierarchy
  • remove unused delay function

@Ehevi Ehevi self-assigned this Aug 15, 2023
@Ehevi Ehevi marked this pull request as draft August 15, 2023 08:33
@Ehevi Ehevi force-pushed the feature/ORCT-144/new-api-periods branch from d4894b5 to 4b01a6a Compare August 15, 2023 08:33
@Ehevi Ehevi changed the title New api periods [ORCT-144] Update periods API Aug 15, 2023
@Ehevi Ehevi force-pushed the feature/ORCT-144/new-api-periods branch 3 times, most recently from 12b1dab to 4dfecfe Compare August 16, 2023 09:49
@Ehevi Ehevi requested a review from xsalonx August 16, 2023 14:45
@Ehevi Ehevi marked this pull request as ready for review August 16, 2023 14:45
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/Model.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/components/messagePanel/messages.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/components/table/obsoletePager.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/components/table/pagination/PaginationModel.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/model/UserPreferences.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/model/data/FetchedDataManager.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/utils/fetch/getRemoteData.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/utils/fetch/getRemoteDataSlice.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/utils/fetch/jsonFetch.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/views/periods/PeriodsModel.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/views/periods/overview/periodsContent.js Show resolved Hide resolved
Ehevi
Ehevi commented Aug 16, 2023
View reviewed changes
app/public/views/periods/table/periodsTableHeader.js Show resolved Hide resolved
@Ehevi Ehevi force-pushed the feature/ORCT-144/new-api-periods branch 2 times, most recently from 47afa6e to 500ad50 Compare August 24, 2023 09:38
@Ehevi Ehevi force-pushed the feature/ORCT-144/new-api-periods branch from 042f065 to a8569ec Compare August 25, 2023 14:26
@Ehevi Ehevi force-pushed the feature/ORCT-144/new-api-periods branch from a8569ec to 9cee950 Compare August 25, 2023 15:59
xsalonx
xsalonx suggested changes Aug 28, 2023
View reviewed changes
app/public/components/table/pageSelector.js Outdated Show resolved Hide resolved
app/public/utils/fetch/jsonFetch.js Outdated Show resolved Hide resolved
app/public/views/periods/overview/dataExport.js Outdated Show resolved Hide resolved
app/public/views/periods/overview/dataExport.js Outdated Show resolved Hide resolved
test/public/components/itemsCounter.test.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx August 28, 2023 11:34
@xsalonx xsalonx merged commit 7f856d9 into master Aug 28, 2023
@xsalonx xsalonx deleted the feature/ORCT-144/new-api-periods branch August 28, 2023 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xsalonx xsalonx xsalonx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ehevi Ehevi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ehevi @xsalonx
Morty Proxy This is a proxified and sanitized view of the page, visit original site.