Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-138] Detector list#160

Merged
xsalonx merged 40 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-138/detector-listAliceO2Group/RunConditionTable:feature/ORCT-138/detector-listCopy head branch name to clipboard
Aug 14, 2023
Merged

[ORCT-138] Detector list#160
xsalonx merged 40 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-138/detector-listAliceO2Group/RunConditionTable:feature/ORCT-138/detector-listCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Aug 10, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • customisable detector list

Notable changes for developers:

  • separate panel for runsPerPeriod created
  • css cleanup
  • remove unused env-cmd module from dependencies
  • multiselect improvement (hide marked options feature)

@Ehevi Ehevi force-pushed the feature/ORCT-138/detector-list branch from 6d21d83 to 85669c7 Compare August 10, 2023 07:37
@Ehevi Ehevi self-assigned this Aug 10, 2023
@Ehevi Ehevi added the frontend label Aug 10, 2023
@Ehevi Ehevi marked this pull request as ready for review August 10, 2023 11:51
@Ehevi Ehevi requested a review from xsalonx August 10, 2023 11:51
@Ehevi Ehevi force-pushed the feature/ORCT-138/detector-list branch from 1e5cc89 to fd0d609 Compare August 10, 2023 13:55
app/public/model/DataAccessModel.js Show resolved Hide resolved
app/public/model/UserPreferences.js Outdated Show resolved Hide resolved
app/public/model/UserPreferences.js Show resolved Hide resolved
app/public/model/data/FetchedData.js Outdated Show resolved Hide resolved
app/public/model/data/FetchedData.js Outdated Show resolved Hide resolved
app/public/model/UserPreferences.js Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx August 11, 2023 07:47
app/public/views/runs/runsPerDataPass/table/header.js Outdated Show resolved Hide resolved
app/public/views/runs/runsPerPeriod/overview/content.js Outdated Show resolved Hide resolved
app/public/model/UserPreferences.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx August 11, 2023 08:59
Copy link
Collaborator

@xsalonx xsalonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit daa3827 to be cherry picked

@Ehevi Ehevi force-pushed the feature/ORCT-138/detector-list branch from 47e1d70 to 1b9d88c Compare August 11, 2023 14:28
@Ehevi Ehevi requested a review from xsalonx August 11, 2023 14:38
@xsalonx xsalonx merged commit 523f482 into master Aug 14, 2023
@xsalonx xsalonx deleted the feature/ORCT-138/detector-list branch August 14, 2023 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.