Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

[ORCT-135] simulation passes piplines#154

Merged
Ehevi merged 27 commits intomasterAliceO2Group/RunConditionTable:masterfrom
improvement/ORCT-135/Simulation-passes-piplinesAliceO2Group/RunConditionTable:improvement/ORCT-135/Simulation-passes-piplinesCopy head branch name to clipboard
Aug 7, 2023
Merged

[ORCT-135] simulation passes piplines#154
Ehevi merged 27 commits intomasterAliceO2Group/RunConditionTable:masterfrom
improvement/ORCT-135/Simulation-passes-piplinesAliceO2Group/RunConditionTable:improvement/ORCT-135/Simulation-passes-piplinesCopy head branch name to clipboard

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Aug 4, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • PR labels are selected

Notable changes for users:

  • introduce endpoints
    • /api/data-passes/:id/simulation-passes
    • /api/simulation-passes
    • /api/simulation-passes/:id/runs
    • /api/simulation-passes/:id/data-passes

Notable changes for developers:

  • add model SimulationPass
  • generic tests for fetch data endpoints in base form (without e.g. filtering)
  • quasi-gerenic tests for services
  • makeHttpRequestForJSON function handles endpoint provided as string
  • some old tests refactor

@xsalonx xsalonx requested a review from Ehevi August 4, 2023 15:26
@xsalonx xsalonx self-assigned this Aug 4, 2023
test/lib/server/routes.test.js Outdated Show resolved Hide resolved
@Ehevi Ehevi merged commit 594af42 into master Aug 7, 2023
@Ehevi Ehevi deleted the improvement/ORCT-135/Simulation-passes-piplines branch August 7, 2023 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.