Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

ORCT-124 Make sidebar collapsible#149

Merged
xsalonx merged 14 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-124/sidebarAliceO2Group/RunConditionTable:feature/ORCT-124/sidebarCopy head branch name to clipboard
Aug 8, 2023
Merged

ORCT-124 Make sidebar collapsible#149
xsalonx merged 14 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-124/sidebarAliceO2Group/RunConditionTable:feature/ORCT-124/sidebarCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Aug 2, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • collapsible sidebar (expand on hover)

Notable changes for developers:

  • use showModal function for detectorIcons

@Ehevi Ehevi added the frontend label Aug 2, 2023
@Ehevi Ehevi self-assigned this Aug 2, 2023
@Ehevi Ehevi changed the title Make sidebar collapsible ORCT-124 Make sidebar collapsible Aug 4, 2023
@Ehevi Ehevi marked this pull request as ready for review August 4, 2023 11:13
@Ehevi Ehevi requested a review from xsalonx August 4, 2023 14:26
Copy link
Collaborator

@xsalonx xsalonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be nice to have possibility to make sidebar 'always visible'

@Ehevi Ehevi force-pushed the feature/ORCT-124/sidebar branch from 10899c3 to 18da02c Compare August 7, 2023 10:24
@Ehevi Ehevi requested a review from xsalonx August 8, 2023 08:49
@Ehevi Ehevi requested a review from xsalonx August 8, 2023 09:28
@xsalonx xsalonx merged commit 0bb568a into master Aug 8, 2023
@xsalonx xsalonx deleted the feature/ORCT-124/sidebar branch August 8, 2023 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.