Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

ORCT-131 Icons cleanup#144

Merged
xsalonx merged 8 commits intomasterAliceO2Group/RunConditionTable:masterfrom
ORCT-131-icons-cleanupAliceO2Group/RunConditionTable:ORCT-131-icons-cleanupCopy head branch name to clipboard
Aug 1, 2023
Merged

ORCT-131 Icons cleanup#144
xsalonx merged 8 commits intomasterAliceO2Group/RunConditionTable:masterfrom
ORCT-131-icons-cleanupAliceO2Group/RunConditionTable:ORCT-131-icons-cleanupCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Jul 31, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • add spaces before size units
  • move page settings inside sidebar
  • add About modal with the link to Icons8

Notable changes for developers:

  • use less for icon style definitions
  • generalize modal component

@Ehevi Ehevi self-assigned this Jul 31, 2023
@Ehevi Ehevi requested a review from xsalonx July 31, 2023 14:11
@Ehevi Ehevi marked this pull request as ready for review July 31, 2023 14:11
app/public/utils/utils.js Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx August 1, 2023 11:10
@xsalonx xsalonx merged commit cb0d334 into master Aug 1, 2023
@xsalonx xsalonx deleted the ORCT-131-icons-cleanup branch August 1, 2023 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.