Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

🧹 Code cleanup#139

Merged
xsalonx merged 20 commits intomasterAliceO2Group/RunConditionTable:masterfrom
improvement/deep-cleanupAliceO2Group/RunConditionTable:improvement/deep-cleanupCopy head branch name to clipboard
Jul 28, 2023
Merged

🧹 Code cleanup#139
xsalonx merged 20 commits intomasterAliceO2Group/RunConditionTable:masterfrom
improvement/deep-cleanupAliceO2Group/RunConditionTable:improvement/deep-cleanupCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Jul 27, 2023

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

Notable changes for developers:

  • remove unused files
  • rename misleading variables
  • model refactor
  • remove spaces from icon names

@Ehevi Ehevi self-assigned this Jul 27, 2023
@Ehevi Ehevi force-pushed the improvement/deep-cleanup branch from 6e1c3a5 to 7fd428e Compare July 28, 2023 08:12
@Ehevi Ehevi marked this pull request as ready for review July 28, 2023 09:07
@Ehevi Ehevi requested a review from xsalonx July 28, 2023 09:07
app/public/Model.js Show resolved Hide resolved
app/public/model/DataAccessModel.js Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx July 28, 2023 10:53
app/public/model/DataAccessModel.js Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx July 28, 2023 11:09
@xsalonx xsalonx merged commit 3c65b62 into master Jul 28, 2023
@xsalonx xsalonx deleted the improvement/deep-cleanup branch July 28, 2023 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.