Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

ORCT-97 Add link to the BK fill page#134

Merged
xsalonx merged 39 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-97-fillsAliceO2Group/RunConditionTable:feature/ORCT-97-fillsCopy head branch name to clipboard
Jul 26, 2023
Merged

ORCT-97 Add link to the BK fill page#134
xsalonx merged 39 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-97-fillsAliceO2Group/RunConditionTable:feature/ORCT-97-fillsCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Jul 25, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • clicking on the fill number in the runs view will take the user to the BK fill page
  • more intuitive link share icon
  • display snackbar after copying the url

Notable changes for developers:

  • copyLinkButton made a separate component
  • rename PrimaryModel to DataAccessModel
  • make title component model independent and move it to the components directory

@Ehevi Ehevi self-assigned this Jul 25, 2023
@Ehevi Ehevi marked this pull request as ready for review July 25, 2023 09:09
@Ehevi Ehevi requested a review from xsalonx July 25, 2023 09:09
xsalonx
xsalonx suggested changes Jul 25, 2023
View reviewed changes
app/public/utils/dataProcessing/dataProcessingUtils.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx July 25, 2023 14:29
xsalonx
xsalonx reviewed Jul 25, 2023
View reviewed changes
app/public/components/chips/indexChip.js Outdated Show resolved Hide resolved
xsalonx
xsalonx suggested changes Jul 25, 2023
View reviewed changes
app/public/Model.js Outdated Show resolved Hide resolved
app/public/components/buttons/copyLinkButton.js Show resolved Hide resolved
app/public/components/chips/indexChip.js Show resolved Hide resolved
xsalonx
xsalonx suggested changes Jul 25, 2023
View reviewed changes
app/public/Model.js Outdated Show resolved Hide resolved
xsalonx
xsalonx suggested changes Jul 25, 2023
View reviewed changes
app/public/components/chips/indexChip.js Show resolved Hide resolved
app/public/model/data/FetchedDataManager.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx July 26, 2023 08:37
xsalonx
xsalonx suggested changes Jul 26, 2023
View reviewed changes
app/public/components/table/title.js Show resolved Hide resolved
app/public/model/navigation/Navigation.js Outdated Show resolved Hide resolved
app/public/utils/filtering/filterUtils.js Show resolved Hide resolved
app/public/views/flags/overview/flagsContent.js Show resolved Hide resolved
app/public/views/runs/runsPerDataPass/overview/content.js Show resolved Hide resolved
app/public/components/chips/indexChip.js Show resolved Hide resolved
app/public/views/userView/data/pagesCellsSpecials.js Show resolved Hide resolved
app/public/model/navigation/Navigation.js Show resolved Hide resolved
app/public/components/buttons/copyLinkButton.js Show resolved Hide resolved
app/public/views/userView/data/table/tablePanel.js Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx July 26, 2023 10:33
xsalonx
xsalonx approved these changes Jul 26, 2023
View reviewed changes
app/public/views/flags/overview/flagsContent.js Outdated Show resolved Hide resolved
app/config/public.js Outdated Show resolved Hide resolved
@xsalonx xsalonx merged commit fdc25a6 into master Jul 26, 2023
@xsalonx xsalonx deleted the feature/ORCT-97-fills branch July 26, 2023 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xsalonx xsalonx xsalonx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ehevi Ehevi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ehevi @xsalonx
Morty Proxy This is a proxified and sanitized view of the page, visit original site.