Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Comments

Close side panel

ORCT-126 Flags assignment dialog#133

Merged
xsalonx merged 27 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-126-flagsAliceO2Group/RunConditionTable:feature/ORCT-126-flagsCopy head branch name to clipboard
Jul 24, 2023
Merged

ORCT-126 Flags assignment dialog#133
xsalonx merged 27 commits intomasterAliceO2Group/RunConditionTable:masterfrom
feature/ORCT-126-flagsAliceO2Group/RunConditionTable:feature/ORCT-126-flagsCopy head branch name to clipboard

Conversation

@Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Jul 21, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • QC type selection modal

Notable changes for developers:

  • navigation regactor
  • link chip refactor (actionChip -> linkChip + component cleanup 🧹)

@Ehevi Ehevi self-assigned this Jul 21, 2023
@Ehevi Ehevi added the frontend label Jul 21, 2023
@Ehevi Ehevi marked this pull request as ready for review July 24, 2023 12:16
@Ehevi Ehevi requested a review from xsalonx July 24, 2023 12:16
app/config/rct-data/quality/operations.js Outdated Show resolved Hide resolved
@Ehevi Ehevi requested a review from xsalonx July 24, 2023 13:36
Copy link
Collaborator

@xsalonx xsalonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access to time based qualities from RunsPerPeriod view should be disabled

@Ehevi Ehevi requested a review from xsalonx July 24, 2023 13:53
app/public/model/PrimaryModel.js Show resolved Hide resolved
@xsalonx xsalonx merged commit 2bec280 into master Jul 24, 2023
@xsalonx xsalonx deleted the feature/ORCT-126-flags branch July 24, 2023 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.