[EMCAL-519] Fix drawing lines for SM geom instead of trigger geom#2640
Open
jokonig wants to merge 1 commit intoAliceO2Group:masterAliceO2Group/QualityControl:masterfrom
Open
[EMCAL-519] Fix drawing lines for SM geom instead of trigger geom#2640jokonig wants to merge 1 commit intoAliceO2Group:masterAliceO2Group/QualityControl:masterfrom
jokonig wants to merge 1 commit intoAliceO2Group:masterAliceO2Group/QualityControl:masterfrom
Conversation
Collaborator
jokonig
commented
Feb 13, 2026
- Wrong geometry used, introduced in [EMCAL-519] Optimize QC Messages for oncall related histograms #2637
- Make line width smaller
- Wrong geometry used, introduced in AliceO2Group#2637 - Make line width smaller
Barthelemy
requested changes
Feb 16, 2026
Collaborator
Barthelemy
left a comment
There was a problem hiding this comment.
Hi
Could you please consider extracting the duplicated code into a method ?
Thank you
| funcs->Remove(obj); | ||
| delete obj; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Please don't repeat the same piece of code several times. Put it in a method and call it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.