Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Fixes to support version 1#491

Merged
jgrosseo merged 2 commits intoAliceO2Group:masterAliceO2Group/O2Physics:masterfrom
jgrosseo:masterjgrosseo/O2Physics:masterCopy head branch name to clipboard
Feb 1, 2022
Merged

Fixes to support version 1#491
jgrosseo merged 2 commits intoAliceO2Group:masterAliceO2Group/O2Physics:masterfrom
jgrosseo:masterjgrosseo/O2Physics:masterCopy head branch name to clipboard

Conversation

@jgrosseo
Copy link
Contributor

@jgrosseo jgrosseo commented Feb 1, 2022

No description provided.

@jgrosseo jgrosseo mentioned this pull request Feb 1, 2022
Merged
@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Feb 1, 2022

Hej @jgrosseo @sawenzel
as described in https://alice.its.cern.ch/jira/browse/O2-2766 this PR solves our issue with fullCI.

@sawenzel
Copy link
Contributor

sawenzel commented Feb 1, 2022

Thanks. Then it would be good to go ahead. I'll take away the draft status to see if it compiles.

@sawenzel sawenzel marked this pull request as ready for review February 1, 2022 12:26
@alibuild
Copy link
Collaborator

alibuild commented Feb 1, 2022

Error while checking build/O2Physics/o2 for 3e0dcaf at 2022-02-01 13:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/491-slc7_x86-64/0/DPG/Tasks/qaEfficiency.cxx:361:62: error: 'const struct o2::soa::Table<o2::aod::mcparticle::Phi, o2::aod::mcparticle::Eta, o2::aod::mcparticle::Pt, o2::aod::mcparticle::P, o2::aod::mcparticle::Y, o2::soa::Index<0, -1>, o2::aod::mcparticle::McCollisionId, o2::aod::mcparticle::PdgCode, o2::aod::mcparticle::StatusCode, o2::aod::mcparticle::Flags, o2::aod::mcparticle::Mother0Id, o2::aod::mcparticle::Mother1Id, o2::aod::mcparticle::Daughter0Id, o2::aod::mcparticle::Daughter1Id, o2::aod::mcparticle::Weight, o2::aod::mcparticle::Px, o2::aod::mcparticle::Py, o2::aod::mcparticle::Pz, o2::aod::mcparticle::E, o2::aod::mcparticle::Vx, o2::aod::mcparticle::Vy, o2::aod::mcparticle::Vz, o2::aod::mcparticle::Vt, o2::aod::mcparticle::ProducedByGenerator<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::FromBackgroundEvent<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::GetGenStatusCode<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::GetProcess<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::IsPhysicalPrimary<o2::aod::mcparticle::Flags> >::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::mcparticle::Phi, o2::aod::mcparticle::Eta, o2::aod::mcparticle::Pt, o2::aod::mcparticle::P, o2::aod::mcparticle::Y, o2::soa::Index<0, -1>, o2::aod::mcparticle::McCollisionId, o2::aod::mcparticle::PdgCode, o2::aod::mcparticle::StatusCode, o2::aod::mcparticle::Flags, o2::aod::mcparticle::Mother0Id, o2::aod::mcparticle::Mother1Id, o2::aod::mcparticle::Daughter0Id, o2::aod::mcparticle::Daughter1Id, o2::aod::mcparticle::Weight, o2::aod::mcparticle::Px, o2::aod::mcparticle::Py, o2::aod::mcparticle::Pz, o2::aod::mcparticle::E, o2::aod::mcparticle::Vx, o2::aod::mcparticle::Vy, o2::aod::mcparticle::Vz, o2::aod::mcparticle::Vt, o2::aod::mcparticle::ProducedByGenerator<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::FromBackgroundEvent<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::GetGenStatusCode<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::GetProcess<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::IsPhysicalPrimary<o2::aod::mcparticle::Flags> >, o2::soa::Table<o2::aod::mcparticle::Phi, o2::aod::mcparticle::Eta, o2::aod::mcparticle::Pt, o2::aod::mcparticle::P, o2::aod::mcparticle::Y, o2::soa::Index<0, -1>, o2::aod::mcparticle::McCollisionId, o2::aod::mcparticle::PdgCode, o2::aod::mcparticle::StatusCode, o2::aod::mcparticle::Flags, o2::aod::mcparticle::Mother0Id, o2::aod::mcparticle::Mother1Id, o2::aod::mcparticle::Daughter0Id, o2::aod::mcparticle::Daughter1Id, o2::aod::mcparticle::Weight, o2::aod::mcparticle::Px, o2::aod::mcparticle::Py, o2::aod::mcparticle::Pz, o2::aod::mcparticle::E, o2::aod::mcparticle::Vx, o2::aod::mcparticle::Vy, o2::aod::mcparticle::Vz, o2::aod::mcparticle::Vt, o2::aod::mcparticle::ProducedByGenerator<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::FromBackgroundEvent<o2::aod::mcparticle::Flags>, o2::aod::mcparticle::GetGenStatusCode<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::GetProcess<o2::aod::mcparticle::Flags, o2::aod::mcparticle::StatusCode>, o2::aod::mcparticle::IsPhysicalPrimary<o2::aod::mcparticle::Flags> > >' has no member named 'has_daughters'; did you mean 'has_daughter0'?
ninja: build stopped: subcommand failed.

Full log here.

@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Feb 1, 2022

Mh, that is unexpected. I will check

@jgrosseo
Copy link
Contributor Author

jgrosseo commented Feb 1, 2022

Mh, that is unexpected. I will check

It is not. We need to wait for the daily O2 tag which @ktf triggered. That's why I left this as draft actually...

@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Feb 1, 2022

ah, right, sorry for my ignorance and thanks for the clarification

@jgrosseo
Copy link
Contributor Author

jgrosseo commented Feb 1, 2022

The tag is there. I made a dummy commit, to run the CI again

@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Feb 1, 2022

Thanks! It seems to work just fine. As soon as this is merged, I will open a PR in O2 to put back the analyses taken out previously.

@jgrosseo jgrosseo merged commit e0fc88b into AliceO2Group:master Feb 1, 2022
@benedikt-voelkel benedikt-voelkel mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mario-krueger mario-krueger Awaiting requested review from mario-krueger

@njacazio njacazio Awaiting requested review from njacazio

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgrosseo @benedikt-voelkel @sawenzel @alibuild
Morty Proxy This is a proxified and sanitized view of the page, visit original site.