Update TPC QA#378
Merged
jgrosseo merged 1 commit intoAliceO2Group:masterAliceO2Group/O2Physics:masterfrom Dec 3, 2021
Merged
Conversation
Collaborator
njacazio
commented
Dec 2, 2021
- Use common utilities
- Add track cuts in QA
- Add event cuts in QA
- Extend available QA plots
Collaborator
|
Error while checking build/O2Physics/o2 for 769c611 at 2021-12-02 13:25: Full log here. |
Member
mario-krueger
left a comment
There was a problem hiding this comment.
Here you may want to give the static_for loop a chance.
Then it would be a bit shorter:
#include "Framework/StaticFor.h"
static_for<0, 8>([&](auto i) {
addParticleHistos<i>(pAxis, ptAxis);
});
mario-krueger
previously approved these changes
Dec 2, 2021
- Use common utilities - Add track cuts in QA - Add event cuts in QA - Extend available QA plots
Collaborator
Author
|
@mario-krueger thanks indeed a lot for the suggestion I will now deploy it everywhere ;) |
jgrosseo
approved these changes
Dec 3, 2021
jezwilkinson
pushed a commit
to jezwilkinson/O2Physics
that referenced
this pull request
Dec 14, 2021
- Use common utilities - Add track cuts in QA - Add event cuts in QA - Extend available QA plots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.