Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

readout-dataflow config-uri update #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 7 commits into from
Jul 9, 2025
Merged

readout-dataflow config-uri update #688

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5160e64
changes for the new readout path
pippohub Jun 23, 2025
cedd34b
changes to move SYNTH readout configs in CONSUL
pippohub Jun 23, 2025
db5ca45
Merge branch 'AliceO2Group:master' into master
pippohub Jul 1, 2025
f7d8921
Merge branch 'AliceO2Group:master' into master
pippohub Jul 9, 2025
0295c6d
modification in the readout config path
pippohub Jul 9, 2025
32e4a57
fixed standalone path
pippohub Jul 9, 2025
98645be
added readout_folder default value
pippohub Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions 9 workflows/readout-dataflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,7 @@ defaults:
qc_remote_jit_enabled: "true"
user: flp
extra_env_vars: ""
readout_folder: "any"
vars:
auto_stop_enabled: "{{ !strings.IsFalsy(auto_stop_timeout) }}"
ddsched_enabled: "{{ epn_enabled == 'true' && dd_enabled == 'true' }}"
Expand All @@ -1359,8 +1360,8 @@ roles:
enabled: "{{ ctp_readout_enabled == 'true' }}"
vars:
detector: "{{ctp_readout_enabled == 'true' ? inventory.DetectorForHost( ctp_readout_host ) : \"\" }}"
readout_cfg_uri_standalone: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.ResolvePath('readout/' + run_type + '/any/readout-standalone-' + ctp_readout_host)}}"
readout_cfg_uri_stfb: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, 'any', 'readout-stfb-' + ctp_readout_host)}}"
readout_cfg_uri_standalone: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, 'standalone', 'readout-standalone-' + ctp_readout_host)}}"
readout_cfg_uri_stfb: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, readout_folder, 'readout-stfb-' + ctp_readout_host)}}"
dd_discovery_ib_hostname: "{{ ctp_readout_host }}-ib" # MUST be defined for all stfb and stfs
# dpl_workflow is set to ctp_dpl_workflow
dpl_workflow: "{{ util.PrefixedOverride( 'dpl_workflow', 'ctp' ) }}"
Expand Down Expand Up @@ -1491,8 +1492,8 @@ roles:
var: it
vars:
detector: "{{ inventory.DetectorForHost( it ) }}"
readout_cfg_uri_standalone: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.ResolvePath('readout/' + run_type + '/any/readout-standalone-' + it)}}"
readout_cfg_uri_stfb: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, 'any', 'readout-stfb-' + it)}}"
readout_cfg_uri_standalone: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, 'standalone', 'readout-standalone-' + it)}}"
readout_cfg_uri_stfb: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, readout_folder, 'readout-stfb-' + it)}}"
Copy link
Collaborator

@knopers8 knopers8 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some correct and backwards-compatible default for readout_folder around here? Otherwise, the template might stop working for setups where we don't use readout_folder, e.g. openstack VMs.

Copy link
Contributor Author

@pippohub pippohub Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @knopers8 I did some tests and if I am not mistaken:

  • if the folders do not exists in CONSUL
  • if the variable is not set
    it goes back to any

Copy link
Contributor Author

@pippohub pippohub Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the path of readout if I don't set anything

consul-ini://localhost:8500/o2/components/readout/ANY/any

Copy link
Contributor Author

@pippohub pippohub Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only part where it fails if I don't set anything is the standalone cfg ... as the standalone path is hardcoded.

But then I am wondering if we use it at all or if we always run with DD enabled.

If we use standalone meaning readout without DD, I can put some protection

Copy link
Collaborator

@knopers8 knopers8 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should indeed go back to any.

It's not very important, but I would propose to anyway list it in defaults, so it is clear what are the variables that the workflow template expects.

Copy link
Collaborator

@knopers8 knopers8 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then I am wondering if we use it at all or if we always run with DD enabled.

I do run readout alone sometimes on my VM.

dd_discovery_ib_hostname: "{{ it }}-ib" # MUST be defined for all stfb and stfs
# dpl_workflow is set to <detector>_dpl_workflow if such an override exists
dpl_workflow: "{{ util.PrefixedOverride( 'dpl_workflow', strings.ToLower( inventory.DetectorForHost( it ) ) ) }}"
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.