Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix closing pipes in basic common task #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Dec 12, 2025
Merged

Fix closing pipes in basic common task #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions 18 executor/executable/basictaskcommon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ func (t *basicTaskBase) startBasicTask() (err error) {
}).
Error("failed to run basic task")

closePipeWriters(stdoutLog, stderrLog)

return err
}
log.WithField("partition", t.knownEnvironmentId.String()).
Expand All @@ -174,12 +176,7 @@ func (t *basicTaskBase) startBasicTask() (err error) {
err = taskCmd.Wait()
// ^ when this unblocks, the task is done

if stdoutLog != nil {
stdoutLog.Close()
}
if stderrLog != nil {
stderrLog.Close()
}
closePipeWriters(stdoutLog, stderrLog)

pendingState := mesos.TASK_FINISHED
var tciCommandStr string
Expand Down Expand Up @@ -252,6 +249,15 @@ func (t *basicTaskBase) startBasicTask() (err error) {
return err
}

func closePipeWriters(stdoutLog *io.PipeWriter, stderrLog *io.PipeWriter) {
if stdoutLog != nil {
stdoutLog.Close()
}
if stderrLog != nil {
stderrLog.Close()
}
}

func (t *basicTaskBase) ensureBasicTaskKilled() (err error) {
if t.taskCmd == nil {
return nil
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.