Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[OCTRL-1076] Unusual number of goroutines stuck in controllable task Kill in executor #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Dec 11, 2025
Merged

[OCTRL-1076] Unusual number of goroutines stuck in controllable task Kill in executor #783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions 5 executor/executable/controllabletask.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,8 +728,8 @@ func (t *ControllableTask) Kill() error {
}).
Debug("state DONE not reached, about to commit transition")

// Call cmd.Commit() asynchronous
commitDone := make(chan *CommitResponse)
// Call cmd.Commit() asynchronous with buffered channel so it doesn't get stuck in a case of timeout
commitDone := make(chan *CommitResponse, 1)
go func() {
var cr CommitResponse
cr.newState, cr.transitionError = cmd.Commit()
Expand Down Expand Up @@ -856,7 +856,6 @@ func (t *ControllableTask) doKill9(pid int) error {
}

func (t *ControllableTask) doTermIntKill(pid int) error {

killErrCh := make(chan error)
go func() {
log.WithField("partition", t.knownEnvironmentId.String()).
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.