Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

OCTRL-678 Pass the error message to BKP in case of GO_ERROR#751

Merged
knopers8 merged 1 commit intoAliceO2Group:masterAliceO2Group/Control:masterfrom
knopers8:bkp-error-reasonknopers8/Control:bkp-error-reasonCopy head branch name to clipboard
Oct 16, 2025
Merged

OCTRL-678 Pass the error message to BKP in case of GO_ERROR#751
knopers8 merged 1 commit intoAliceO2Group:masterAliceO2Group/Control:masterfrom
knopers8:bkp-error-reasonknopers8/Control:bkp-error-reasonCopy head branch name to clipboard

Conversation

@knopers8
Copy link
Collaborator

An error message is now propagated to kafka events just before scheduling a GO_ERROR transition.

An error message is now propagated to kafka events just before scheduling a GO_ERROR transition.
@knopers8
Copy link
Collaborator Author

@graduta FYI. Let me know if you would like a core binary to give it a spin.

Copy link
Collaborator

@justonedev1 justonedev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you are not sending the error message directly from GO_ERROR transition from the environment?

core/environment/environment.go Show resolved Hide resolved
core/environment/utils.go Show resolved Hide resolved
@knopers8
Copy link
Collaborator Author

knopers8 commented Oct 8, 2025

Is there a reason why you are not sending the error message directly from GO_ERROR transition from the environment?

Yes, for two reasons:

  • it's not known anymore, but we could work it around by adding it as a string argument in NewGoErrorTransition and adding the call to GoErrorTransition.do(). But...
  • If a critical hook for before_GO_ERROR fails, we will never reach GoErrorTransition.do().

core/environment/environment.go Show resolved Hide resolved
@knopers8 knopers8 merged commit 9588d2f into AliceO2Group:master Oct 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.