Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

TPC QC: add DCS points qc for temperature sensors#8745

Merged
shahor02 merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
tklemenz:DCSP_temptklemenz/AliceO2:DCSP_tempCopy head branch name to clipboard
May 13, 2022
Merged

TPC QC: add DCS points qc for temperature sensors#8745
shahor02 merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
tklemenz:DCSP_temptklemenz/AliceO2:DCSP_tempCopy head branch name to clipboard

Conversation

@tklemenz
Copy link
Contributor

@tklemenz tklemenz commented May 6, 2022

No description provided.

Detectors/TPC/qc/include/TPCQC/DCSPTemperature.h Outdated Show resolved Hide resolved
Detectors/TPC/qc/include/TPCQC/DCSPTemperature.h Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/DCSPTemperature.cxx Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/DCSPTemperature.cxx Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/DCSPTemperature.cxx Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/DCSPTemperature.cxx Outdated Show resolved Hide resolved
@tklemenz
Copy link
Contributor Author

I addressed all the points.

Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tklemenz , please remove the WIP

Comment on lines 39 to 40
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cStats->SetBit(TObject::kCanDelete);
cSensorsMultiGraph->SetBit(TObject::kCanDelete);

should belong to objects in the canvas.

@tklemenz tklemenz changed the title [WIP] TPC QC: add DCS points qc for temperature sensors TPC QC: add DCS points qc for temperature sensors May 13, 2022
@wiechula
Copy link
Collaborator

@shahor02 , @davidrohr , failure seems unrelated, can this be merged?

@shahor02 shahor02 merged commit bf31f82 into AliceO2Group:dev May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.