DPL Analysis: add template to declare index binding equivalence#8002
Closed
aalkin wants to merge 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aalkin:index-compatibility-declarationaalkin/AliceO2:index-compatibility-declarationCopy head branch name to clipboard
Closed
DPL Analysis: add template to declare index binding equivalence#8002aalkin wants to merge 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom aalkin:index-compatibility-declarationaalkin/AliceO2:index-compatibility-declarationCopy head branch name to clipboard
aalkin wants to merge 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aalkin:index-compatibility-declarationaalkin/AliceO2:index-compatibility-declarationCopy head branch name to clipboard
Conversation
Collaborator
|
Very nice! Is something still missing as it is in draft? |
Member
Author
|
@jgrosseo it can only be tested together with your versioning modification, it would be easier if you integrate this change there. |
Collaborator
|
OK, I'll do that. |
Member
Author
|
@jgrosseo this change should fix the "cannot be used in constexpr" problem, and the declaration itself can be placed outside |
1620500 to
e770b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jgrosseo this should solve the index problem with versioning, for example
DECLARE_EQUIVALENT_FOR_INDEX(McParticles, McParticles_001)