Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Introduction of a second charge-collection table in ALPIDE response#7977

Merged
shahor02 merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
AlexBigO:ServiceWorkAlexBigO/AliceO2:ServiceWorkCopy head branch name to clipboard
Feb 7, 2022
Merged

Introduction of a second charge-collection table in ALPIDE response#7977
shahor02 merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
AlexBigO:ServiceWorkAlexBigO/AliceO2:ServiceWorkCopy head branch name to clipboard

Conversation

@AlexBigO
Copy link
Contributor

With this PR we introduced a second charge-collection table in ALPIDE response.
A possibility to choose either of the tables or both from the command line is implemented as well.

For the moment, the second table is just a clone of the previously existing table for Vbb=-3V.
But it will eventually be replaced with a true table for Vbb=0V.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexBigO

Thanks for the development. Not sure it makes sense to upload 800+ dummy files cloned from Vbb0 just to override them later by real Vbb3. Since the Vbb3 anyway cannot be used now, I would propose to leave the code part of your PR (making sure that if Vbb3 is selected it prints a proper message and produce fatal) + moving current data files to the proper Vbb0 directory.

@AlexBigO
Copy link
Contributor Author

AlexBigO commented Jan 24, 2022

Hi @AlexBigO

Thanks for the development. Not sure it makes sense to upload 800+ dummy files cloned from Vbb0 just to override them later by real Vbb3. Since the Vbb3 anyway cannot be used now, I would propose to leave the code part of your PR (making sure that if Vbb3 is selected it prints a proper message and produce fatal) + moving current data files to the proper Vbb0 directory.

Hi @shahor02

It is not yet clear when the true table for Vbb=0 will become available. The current idea is to try to tweak the existing table for Vbb=-3V, working freely on an independent clone of the table.
Does this create problems with managing the repository? If yes, we can remove the clone, of course.
But eventually, we would have to commit the second table anyway.

@shahor02
Copy link
Collaborator

Hi @AlexBigO
I let to @ktf to comment if committing 800+ new files which are anyway cannot be used until they are completely overwritten (not just a small diff applied) will cause extra stress to the git repository. Personally, I would not do this.

@ktf
Copy link
Member

ktf commented Jan 24, 2022

I agree it would be best to avoid it. How much bigger does the repository become? Do you have any other way this could be done?

@shahor02
Copy link
Collaborator

I agree it would be best to avoid it. How much bigger does the repository become? Do you have any other way this could be done?

6.4MB made of 817 files, duplicated from the data of the currently used map as a placeholder for the alternative map, which will be produced later.

@shahor02
Copy link
Collaborator

@AlexBigO thanks for changing! Could you apply clang-format, then I'll approve to start CI tests.

shahor02
shahor02 previously approved these changes Jan 27, 2022
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to trigger CI tests.

@iouribelikov
Copy link
Collaborator

@everybody. I do not understand... This PR was already "in green" during the weekend.
Now, 5 checks failed :(
And I do not see anything calling for corrections in the logs.

Cannot we simply merge this PR ?

@shahor02
Copy link
Collaborator

shahor02 commented Feb 7, 2022

some builders are failing to start. Merging.

@shahor02 shahor02 merged commit 63df70a into AliceO2Group:dev Feb 7, 2022
@ktf
Copy link
Member

ktf commented Feb 8, 2022

For the record, Gitlab at CERN is having troubles, so this might result in failed builds with no logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.