Introduction of a second charge-collection table in ALPIDE response#7977
Introduction of a second charge-collection table in ALPIDE response#7977shahor02 merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
…MFT, and ITS Inner and Outter Barrel
shahor02
left a comment
There was a problem hiding this comment.
Hi @AlexBigO
Thanks for the development. Not sure it makes sense to upload 800+ dummy files cloned from Vbb0 just to override them later by real Vbb3. Since the Vbb3 anyway cannot be used now, I would propose to leave the code part of your PR (making sure that if Vbb3 is selected it prints a proper message and produce fatal) + moving current data files to the proper Vbb0 directory.
Hi @shahor02 It is not yet clear when the true table for Vbb=0 will become available. The current idea is to try to tweak the existing table for Vbb=-3V, working freely on an independent clone of the table. |
|
I agree it would be best to avoid it. How much bigger does the repository become? Do you have any other way this could be done? |
6.4MB made of 817 files, duplicated from the data of the currently used map as a placeholder for the alternative map, which will be produced later. |
|
@AlexBigO thanks for changing! Could you apply clang-format, then I'll approve to start CI tests. |
shahor02
left a comment
There was a problem hiding this comment.
approving to trigger CI tests.
|
@everybody. I do not understand... This PR was already "in green" during the weekend. Cannot we simply merge this PR ? |
|
some builders are failing to start. Merging. |
|
For the record, Gitlab at CERN is having troubles, so this might result in failed builds with no logs. |
With this PR we introduced a second charge-collection table in ALPIDE response.
A possibility to choose either of the tables or both from the command line is implemented as well.
For the moment, the second table is just a clone of the previously existing table for Vbb=-3V.
But it will eventually be replaced with a true table for Vbb=0V.