Add ZDC table to the AOD producer#7343
Add ZDC table to the AOD producer#7343sawenzel merged 14 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
|
|
||
| // zdc helper maps to avoid a number of "if" statements | ||
| map<string, float> mZDCEnergyMap; | ||
| map<int, float> mZDCTDCMap; |
There was a problem hiding this comment.
could you add what is being mapped to what in the comments?
Is map better than unordered_map ?
There was a problem hiding this comment.
Hi @sawenzel. I have added some comments for these maps. Concerning performance of map and unordered_map, I think in this case there should be no real differences, since these maps will consist of a small number of key-value pairs. Here, keys correspond to ZDC sub-parts and TDC channels, so their number is small indeed. Perhaps, performance-wise it would be better to simply use if-clauses, but there will be a lot of them :)
There was a problem hiding this comment.
Hello,
I'm from the ZDC team. To me it looks a bit strange to have a map that uses signal TDC ids and another that uses signal names. One should probably unify the approach and use signal names for both maps. What do you think?
There was a problem hiding this comment.
Hi @cortesep. Thank you for your comment. I will try to clean it up a bit.
| O2::SimConfig | ||
| O2::DataFormatsFT0 | ||
| O2::Steer | ||
| O2::ZDCBase |
There was a problem hiding this comment.
Is this global change necessary?
There was a problem hiding this comment.
Sorry, it is a typo. I just added ZDCBase, but accidentally indented some lines.
…d-updates � Conflicts: � Detectors/AOD/src/AODProducerWorkflowSpec.cxx
…d-updates � Conflicts: � Detectors/AOD/src/AODProducerWorkflowSpec.cxx
|
@nburmaso : I thought this was merged already but apparently the auto-merge feature didn't go through. Unfortunately, we now have merge conflicts again. Could you please take a look? |
Head branch was pushed to by a user without write access
|
Hi @sawenzel. I have resolved the conflicts and cleaned up the code a bit. |
* Add ZDC table to the AOD producer
Hi @sawenzel, @shahor02. While the reader problem is not resolved yet (related to some issue in the reader, which I contacted Ruben about; see log attached), I'm putting the code I prepared for the ZDC table in this draft PR to have it ready.
test.log