DPL Analysis: Introducing conditional expressions#6753
Merged
ktf merged 4 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Jul 27, 2021
Merged
DPL Analysis: Introducing conditional expressions#6753ktf merged 4 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
ktf merged 4 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
* `ifnode(condition, then, else)` operation is added to expressions * these can be nested * all three arguments can be arbitrary valid expressions * `condition` needs to have boolean result, `then` and `else` should return similar types (ideally the same - both floats, or both boolean, etc.) * Added a test * Added `conditionalExpressions.cxx` tutorial example (note that it uses bitwise operations in filter expression and thus will only work as is with arrow > 3)
Collaborator
|
Mac is not happy... |
Member
Author
|
There was an issue with operations between configurables and literal values. In the filter expressions one would may need to use |
This was referenced Jul 30, 2021
skundu692
pushed a commit
to skundu692/AliceO2
that referenced
this pull request
Aug 10, 2021
`ifnode(condition, then, else)` operation is added to expressions. These can be nested and all three arguments can be arbitrary valid expressions. `condition` needs to have boolean result, `then` and `else` should return similar types (ideally the same - both floats, or both boolean, etc.). A `conditionalExpressions.cxx` tutorial example is added (note that it uses bitwise operations in filter expression and thus will only work as is with arrow > 3).
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
`ifnode(condition, then, else)` operation is added to expressions. These can be nested and all three arguments can be arbitrary valid expressions. `condition` needs to have boolean result, `then` and `else` should return similar types (ideally the same - both floats, or both boolean, etc.). A `conditionalExpressions.cxx` tutorial example is added (note that it uses bitwise operations in filter expression and thus will only work as is with arrow > 3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifnode(condition, then, else)operation is added to expressionsconditionneeds to have boolean result,thenandelseshould return similar types (ideally the same - both floats, or both boolean, etc.)conditionalExpressions.cxxtutorial example (note that it uses bitwise operations in filter expression and thus will only work 'as is' with arrow > 3.0)@jgrosseo this is fully functional