DPL: force processing of region callback without waiting for data#6621
Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Jul 12, 2021
Merged
DPL: force processing of region callback without waiting for data#6621ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
Without this, it possible that a late arriving event will not be processed until some data actually arrives on one of the channels, unblocking the event loop. This should obviate to the problem by triggering an aync libuv event which will unblock the event loop without the need for data.
Member
Author
|
@davidrohr not tested, but should improve the delivery of the callbacks. |
davidrohr
approved these changes
Jul 12, 2021
Collaborator
davidrohr
left a comment
There was a problem hiding this comment.
I checked this and it doesn't break my tests.
But we need a release and RPMs to deploy on the EPNs and test with AliECS. Probably still needs some patches elsewhere.
Since it doesn't break anything, I propose to merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, it is possible that a late arriving event will not be processed
until some data actually arrives on one of the channels, unblocking the event
loop. This should obviate to the problem by triggering an aync libuv event
which will unblock the event loop without the need for data.