Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

DPL Analysis: make all indices behave consistently with Filtered binding#6607

Merged
jgrosseo merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aalkin:fix-arrayslice-indexaalkin/AliceO2:fix-arrayslice-indexCopy head branch name to clipboard
Jul 12, 2021
Merged

DPL Analysis: make all indices behave consistently with Filtered binding#6607
jgrosseo merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aalkin:fix-arrayslice-indexaalkin/AliceO2:fix-arrayslice-indexCopy head branch name to clipboard

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Jul 8, 2021

  • Introduce rawIteratorAt and rawSlice functions, that use unfiltered base table
  • Make sure index, slice index and array index always use unfiltered base table when dereferencing
  • Introduce slice function to get typed slice of the table, that takes filters into account
  • Add tests

replaces #6602

@aalkin aalkin requested a review from a team as a code owner July 8, 2021 09:22
@jgrosseo jgrosseo merged commit 6d593ff into AliceO2Group:dev Jul 12, 2021
@aalkin aalkin deleted the fix-arrayslice-index branch July 21, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.