Fix some of the ALICE 3 geometry issues#6562
Merged
sawenzel merged 3 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Jul 8, 2021
Merged
Fix some of the ALICE 3 geometry issues#6562sawenzel merged 3 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
sawenzel merged 3 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
sawenzel
previously approved these changes
Jul 1, 2021
Collaborator
|
@afurs : A think your recent PR broke the MacOS builds. Could you please take a look and fix asap? |
afurs
pushed a commit
to afurs/AliceO2
that referenced
this pull request
Jul 2, 2021
Collaborator
Collaborator
|
@afurs : Thanks and no worries. |
ktf
pushed a commit
that referenced
this pull request
Jul 2, 2021
qgp
approved these changes
Jul 6, 2021
Contributor
|
Hi everyone, I am sorry to be pushy... but Bernhard and I would really like to have this merged soon so that we can run our strangeness tracking on batch farms. Would it be possible to merge this soon? Thank you very much! |
Collaborator
|
Hi David, all, Jochen already approved, so it is not clear to me where/why this is stuck. I don't think I can do much myself, I don't even have the option to approve as far as I can see... It may need a force-merge to clear the errors from the CI? |
marcovanleeuwen
approved these changes
Jul 8, 2021
Collaborator
|
Unfortunately github does not show PRs as an approved status when it's only partially approved, so it slipped my attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sawenzel @qgp,
I just fixed some default values for the geometry of ALICE 3. I kindly need your approval and merge.
@rpezzi I am stll trying to do the fix for FT3 escavations in vacuum volume. Unfortunately tentatives so far failed for some yet unknown reason.
Difference with TRK is that I have to apply a transformation (z-translations) to the shapes of inner disk-holes and somehow this breaks the geometry streaming on file. For TRK it works because all the holes are centered in 0,0,0 and transformations are not required. I'll investigate a bit more on that.