CCDB populator will match payload and wrapper according to DataDescription#6150
Merged
shahor02 merged 14 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom May 19, 2021
chiarazampolli:WildcardedSpec_part2chiarazampolli/AliceO2:WildcardedSpec_part2Copy head branch name to clipboard
Merged
CCDB populator will match payload and wrapper according to DataDescription#6150shahor02 merged 14 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom chiarazampolli:WildcardedSpec_part2chiarazampolli/AliceO2:WildcardedSpec_part2Copy head branch name to clipboard
shahor02 merged 14 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
chiarazampolli:WildcardedSpec_part2chiarazampolli/AliceO2:WildcardedSpec_part2Copy head branch name to clipboard
Conversation
Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
clang-format
abfd463 to
5204e5f
Compare
Collaborator
|
Hi @chiarazampolli and don't understand why it happens. You've suppressed the should be added to this linkdef. |
Collaborator
Author
|
The test that fails in O2 is not related to this PR: at least I think. @ktf , @TimoWilken , @shahor02 , any idea what it is? Chiara |
Collaborator
|
@chiarazampolli : still fails on the the same |
Collaborator
Author
I was just about to take a look and google for hints... Thanks for trying, let's see if your idea works. |
Collaborator
Author
|
Hi @shahor02 , Now there are different errors: |
Member
|
I think you need to move the |
Collaborator
Author
|
Ciao @ktf , I moved the include and the pragma too, as we discussed. Let's see. |
Member
|
The pragma needs to stay inside the |
Collaborator
Author
|
ok, thanks, then I misunderstood. |
Collaborator
|
Hi, |
Member
|
@shahor02 we could indeed try with adding |
Collaborator
Author
|
Ok, it failed again. I will try to add the include in a file. |
Collaborator
Author
|
Now macos is happy! |
Collaborator
Author
|
These are not from my PR: If all the rest is green, we should merge, unless we want to have an explicit blessing by the detectors (@shahor02 ). |
Collaborator
|
@chiarazampolli after your update I can't see anymore what was reported for these macros. What was a problem? |
Collaborator
Author
|
Just trailing whitespaces. See https://github.com/AliceO2Group/AliceO2/pull/6150/checks?check_run_id=2617983370, from "Space checker". |
Collaborator
Author
|
macos seems spurious - pinging @ktf , @TimoWilken. |
Collaborator
Author
|
Hi @shahor02 , Finally all tests have run. Space checker fails in other macros that I did not touch. Should we ask the detectors to validate, or merge? Chiara |
Collaborator
|
Finally... I would merge it, nothing currently critically depends on this, can fix in other PR if problems are found. |
Merged
cortesep
pushed a commit
to cortesep/AliceO2
that referenced
this pull request
Jun 11, 2021
…ption (AliceO2Group#6150) * changes for wildcarded DataSpec * Using constructor of InputSpec with only Origin * Modify detector calib.code to match to new CCDB populator inputs (#32) Co-authored-by: shahoian <ruben.shahoyan@cern.ch> * Adapting new devices clang-format * Removing obsolete DCS processing * Adding some pragma rules * remove deleted macro from exclusion list * Remove tabs * Include unordered_map to test if it helps with dictionary building * Move include and pragma outside the ifdef (Giulio's advice) * Update DetectorsDCSLinkDef.h * Moving include of unordered_map to an include file in the library * clang-format * remove trailing space Co-authored-by: Ruben Shahoyan <shahor02@users.noreply.github.com> Co-authored-by: shahoian <ruben.shahoyan@cern.ch> Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to send to the CCDB populator multiple CCDB objects at the same time. The pairing paylod <--> wrapper will be done by the framework based on the Data Description.