Software event filtering for Run 3 pp#5967
Software event filtering for Run 3 pp#5967jgrosseo merged 18 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
There was a problem hiding this comment.
Why do you need a separate mechanism than the Configurables?
There was a problem hiding this comment.
If Configurables support nested maps we can use them
There was a problem hiding this comment.
Do you mean the case of "mScalers->GetBinContent(1)" with 0 entries?
There was a problem hiding this comment.
{false} should auto-expand into a n element array if I am not mistaken
There was a problem hiding this comment.
Indeed, funny thing (that burned me once) it is not true if you do it with {true}... we will fix this!
|
I posted a few, mostly minor comments |
|
Ciao @jgrosseo, I realised that we implemented you comments but we did not ping you back! We are ready for the second round of review |
There was a problem hiding this comment.
Can we have a longer (more meaningful) name?
|
All good for me, except the name of the executable. Could you quickly fix this, and then we start the CI? |
|
Fixed, let's see what the CI says |
Co-authored-by: Maximiliano Puccio <mpuccio@users.noreply.github.com>
... and the software sits outside the analysis task directory
Co-authored-by: Stefano Trogolo <strogolo@users.noreply.github.com>
|
Sorry, I had to update here since the PID enums were renamed while this was open and this dismissed your review @jgrosseo |
|
CI is happy :) |
This is the first version of the core event filtering framework we developed with @mpuccio.
@iarsene @jgrosseo have a look and comment!
cc: @pbuehler @pchristi @fgrosa