PWGHF: Add Xtask, add CollisionId to candidate table#5469
Merged
jgrosseo merged 23 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Mar 18, 2021
Merged
PWGHF: Add Xtask, add CollisionId to candidate table#5469jgrosseo merged 23 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
jgrosseo merged 23 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
vkucera
requested changes
Feb 26, 2021
vkucera
requested changes
Mar 1, 2021
vkucera
requested changes
Mar 4, 2021
vkucera
requested changes
Mar 4, 2021
vkucera
requested changes
Mar 5, 2021
vkucera
requested changes
Mar 7, 2021
vkucera
reviewed
Mar 15, 2021
vkucera
previously approved these changes
Mar 16, 2021
Collaborator
There was a problem hiding this comment.
@ginnocen Looks fine to me.
@rspijkers Please fix the conflicts.
Collaborator
|
@rspijkers there is a little conflict, can you fix it? thanks! |
Adds duplicate track check in X task.
- added home institute (UU) - changed pion loop statement (shouldn't do anything different) - deleted print statements - deleted JpsiTracks, no longer needed (only used for print statements) - edited some variable names I forgot last commit
Only applied to X task for now
instead of making it a separate workflow - also removes aod::Colls from both X and B Tasks (the declaration has to be removed from B task still) - adds cfgc to taskX.cxx
- use the collision row for collision ID - removed obsolete table and task from B task - fix indentation in HFSecondaryVertex.h
- removed charge check - changed TPC checks
To be removed before merging
- Y cut instead of eta cut on the Jpsi - also corrected x-axis label of Jpsi mass histo
- also changed sign and index checks
ginnocen
approved these changes
Mar 17, 2021
jgrosseo
reviewed
Mar 18, 2021
| template <typename T> | ||
| bool selectionPIDTPC(const T& track, int nSigmaCut) | ||
| { | ||
| if (nSigmaCut > 999.) { |
Collaborator
There was a problem hiding this comment.
Why do we need this check?
jgrosseo
approved these changes
Mar 18, 2021
Collaborator
jgrosseo
left a comment
There was a problem hiding this comment.
Comment will be considered later. Merging now.
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the X task to O2. This pull request replaces @ginnocen PR #5409