[MCH] fix bug in Segmentation::findPadPairByPosition#5451
Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Feb 19, 2021
aphecetche:bugfix-mch-segmentation-is-validaphecetche/AliceO2:bugfix-mch-segmentation-is-validCopy head branch name to clipboard
Merged
[MCH] fix bug in Segmentation::findPadPairByPosition#5451ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom aphecetche:bugfix-mch-segmentation-is-validaphecetche/AliceO2:bugfix-mch-segmentation-is-validCopy head branch name to clipboard
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aphecetche:bugfix-mch-segmentation-is-validaphecetche/AliceO2:bugfix-mch-segmentation-is-validCopy head branch name to clipboard
Conversation
In the case where this method returns false (at least one cathode plane has no pad at this position), the pass-by-reference b and nb indices were not (always) meaningful, preventing to deduce which side (bending, non bending or both) was actually missing. Also rationalize the meaning of isValid(padindex) for both Cathode and Segmentation levels : a padindex is valid if it's in the range 0..npads-1 where npads is the number of pads for either the cathode (for Cathode object) or both cathodes (for Segmentation object).
Collaborator
Author
|
@pillot could you have a look ? The changes should hopefully correspond to what we discussed this morning. |
Collaborator
|
@aphecetche it looks fine to me, thanks! |
Collaborator
Author
|
@TimoWilken do I have to do something here or will the fullCI be ran again at some point ? |
Collaborator
Author
|
@davidrohr @shahor02 @ktf could someone with the relevant rights please approved and/or merge this PR ? Turns out I cannot merge my owns 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where this method returns false (at least one cathode plane has
no pad at this position), the pass-by-reference b and nb
indices were not (always) meaningful, preventing to deduce which
side (bending, non bending or both) was actually missing.
Also rationalize the meaning of isValid(padindex) for both Cathode and
Segmentation levels : a padindex is valid if it's in the range
0..npads-1 where npads is the number of pads for either the cathode (for
Cathode object) or both cathodes (for Segmentation object).