PWGHF: Implementation of Lc --> K0s+p by chiarazampolli · Pull Request #5257 · AliceO2Group/AliceO2

chiarazampolli · Jan 21, 2021

some changes

update

Expect that v0s are already built and preselected

some more work

A bit further, but not compiling

just a temp commit

Compiling version - still refinements needed

further work

temp

not working

not working again, needed for debug

ppp

working version - cuts still to be tuned

chiarazampolli · Jan 22, 2021

@vkucera , wait before reviewing, there are some things I want to improve.
Thanks!

chiarazampolli · Jan 23, 2021

Hello @vkucera , @ginnocen ,
Debug plots are still missing, but I think that the review of this can start.
Thanks!
Chiara

chiarazampolli · Feb 12, 2021

Hello @vkucera , @ginnocen , @nzardosh ,

I pushed the first version of the selector. Note that:

the cuts for the selection are taken from https://alice-notes.web.cern.ch/system/files/notes/analysis/844/2020-11-10-ALICE_analysis_note_0.pdf
the bayes PID used in the AN note is not yet there, as I think it is not in the framework yet (@njacazio )
The code runs, but I did not check what gets selected yet.

Since we agreed at the meeting on Tue (9.02) that the review for this PR can start, I kept this commit separate. Let me know if you want that I squash them.

Next is the task to plot the observables of the selected candidates (equivalent to taskD0.cxx).

chiarazampolli · Feb 18, 2021

Last commit does not compile, but since the review has not started yet, it is no problem. I will try to fix it tomorrow, if I don't manage, I will revert.

chiarazampolli · Feb 19, 2021

Now compiling.

chiarazampolli · Feb 19, 2021

Hello @vkucera @ginnocen ,
Now also the histogramming is working. Missing is the MC part, but as we said, the review can start when you are ready (I will continue pushing here if I don't get comments).
I have realized though that it would be better not to wait too long to merge this PR, since it involves also 2 HF classes that might change independently from my PR, which might then create troubles.

chiarazampolli · Feb 19, 2021

Hello,
As said on Tuesday, I change this PR to "ready for review", to verify that the CI does not complain.
But then it should be moved back to "Draft" so that it is not merged accidentally by someone before @ginnocen and @vkucera review it.
Chiara

vkucera

Hi @chiarazampolli , a couple of first comments.
In general:

Fix naming (camelCase).
Add missing readability braces around statements.

Analysis/Tasks/PWGHF/HFTrackIndexSkimsCreator.cxx

Analysis/Tasks/PWGHF/taskLcK0sp.cxx

Analysis/Tasks/PWGHF/HFTrackIndexSkimsCreator.cxx

Analysis/Tasks/PWGHF/CMakeLists.txt

chiarazampolli · Feb 23, 2021

The error in the CI (which is now re-running because I added a further commit) seems to be coming from CPV:

Launching task: /mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/O2/5257-1/prodtests/full-system-test/dpl-workflow.sh &> reco_NOGPU.log &
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log-[61732:mft-tracker]: [14:29:12][INFO] Found tracks CA: 0
reco_NOGPU.log-[61732:mft-tracker]: [14:29:12][INFO] ROframe: 9, clusters loaded : 28765
reco_NOGPU.log:[61858:CPVClusterizerSpec]: [14:29:12][ERROR] Exception caught: bitset::test: __position (which is 23040) >= _Nb (which is 23040) 
reco_NOGPU.log-[61858:CPVClusterizerSpec]: /mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/O2/5257-1/lib/libO2FrameworkFoundation.so(_ZN2o29framework13runtime_errorEPKc+0x74)[0x7f26d3145a54]
reco_NOGPU.log-[61858:CPVClusterizerSpec]: /mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/O2/5257-1/lib/libO2Framework.so(+0x1106a5)[0x7f26d425f6a5]

Pinging @peressounko , @shahor02 .

Chiara

peressounko · Feb 23, 2021

Dear @chiarazampolli CPV bug should be fixed in PR #5499

chiarazampolli · May 6, 2021

Hello @ddobrigk ,

This PR touches also your code in PWGLF, where I added some functionalities to do debugging. Could you please take a look and let me know in case you spot anything wrong or that you don't like?

@ginnocen , @iarsene , @jgrosseo : please, do not approve before David's agree that all is fine! (in case the tests are fine, of course).

Thanks in advance!

Chiara

ktf · May 8, 2021

Analysis/Tasks/Utils/include/AnalysisTasksUtils/UtilsDebugLcK0Sp.h

For next time, do not comment code please.

Is it the use of /* */ that is problematic?

Removed, but I would also like to know what is wrong/bad with it.

Chiara

clang-format leftovers fixed Clang-format Few more Clang-format removing useless namespace declaration Optimization more clang-format typo Remove commented out code

ddobrigk · May 17, 2021

I took a look at the changes to the v0 tasks - everything looks fine, as only a debug option was added, essentially. Please feel free to carry on :-D

chiarazampolli · May 17, 2021

Ciao @ddobrigk ,

Thanks! @ginnocen , @iarsene , @jgrosseo , could you merge now? I think the PR got all needed approvals.

Chiara

This reverts commit 43ef15b. ODOD On branch xicc_newgood

This reverts commit 43ef15b.

* First version of skimming for Lc some changes update Expect that v0s are already built and preselected some more work A bit further, but not compiling just a temp commit Compiling version - still refinements needed further work temp not working not working again, needed for debug ppp working version - cuts still to be tuned clang few changes clang further work forgotten file forgotten file Fixing copy/paste error clang * Selector for Lc --> K0s+p added clang-format * First version of histogramming task - not compilinggit add Analysis/Tasks/PWGHF/CMakeLists.txt Analysis/Tasks/PWGHF/HFCandidateCreatorCascade.cxx Analysis/Tasks/PWGHF/taskLcK0sp.cxx fix compilation fixes clang * Avoid passing indices of daughters when building v0 In case, one would need a o2::dataformats::GlobalTrackID.h, but anyway it is not used. Fix * Comments by Vit clang Fixes for braces clang * Adding pT V0 daugh, and swapping V0 and bach (as in AliPhysics) clang * First version using MC info. To be investigated: - why no V0 in the V0 table is a K0s that comes from a Lc? - the RecoDecay::isMatchedMCGen might need some adjustments, being checked Fixes Format * recent work - to be cleaned-up * Update Lc -> K0S+p to do MC checks too. Adding also the possibility to do local debugging with an AO2D file from any production. format Stupid fix * Revisiting debugging * Anton's comments clang-format * Implementation of comments by Anton and Vit misc fixes clang-format * more comments by Vit clang-format * Further comments implemented clang-format leftovers fixed Clang-format Few more Clang-format removing useless namespace declaration Optimization more clang-format typo Remove commented out code

chiarazampolli requested a review from ginnocen as a code owner January 21, 2021 23:06

chiarazampolli force-pushed the LcV0p branch from f3efac4 to 3491776 Compare January 21, 2021 23:20

chiarazampolli marked this pull request as draft January 22, 2021 15:05

chiarazampolli changed the title ~~PWGHF: Draft: First version of skimming for Lc~~ PWGHF: First version of skimming for Lc --> K0s+p Jan 22, 2021

chiarazampolli force-pushed the LcV0p branch from 3491776 to 28c19fd Compare January 23, 2021 00:24

chiarazampolli force-pushed the LcV0p branch 4 times, most recently from 33036cf to bbaa4c0 Compare February 8, 2021 10:35

chiarazampolli force-pushed the LcV0p branch 2 times, most recently from df02514 to 2fd8a9a Compare February 12, 2021 23:08

chiarazampolli force-pushed the LcV0p branch from b65bc37 to 695f81c Compare February 19, 2021 10:28

chiarazampolli force-pushed the LcV0p branch from 695f81c to ada3c09 Compare February 19, 2021 11:11

chiarazampolli marked this pull request as ready for review February 19, 2021 11:14

chiarazampolli requested review from iarsene and jgrosseo as code owners February 19, 2021 11:14

chiarazampolli force-pushed the LcV0p branch 2 times, most recently from 18c9e4f to 898b46e Compare February 20, 2021 00:34

vkucera reviewed Feb 20, 2021

View reviewed changes

chiarazampolli force-pushed the LcV0p branch 2 times, most recently from 42e5583 to 83f691d Compare February 23, 2021 12:01

chiarazampolli force-pushed the LcV0p branch from 6f9a678 to 7202f80 Compare May 6, 2021 21:58

vkucera marked this pull request as ready for review May 6, 2021 21:59

vkucera previously approved these changes May 6, 2021

View reviewed changes

vkucera dismissed their stale review via 3de3b36 May 7, 2021 12:43

vkucera previously approved these changes May 7, 2021

View reviewed changes

ktf reviewed May 8, 2021

View reviewed changes

Further comments implemented

93f9956

clang-format leftovers fixed Clang-format Few more Clang-format removing useless namespace declaration Optimization more clang-format typo Remove commented out code

chiarazampolli dismissed vkucera’s stale review via 93f9956 May 10, 2021 09:05

chiarazampolli force-pushed the LcV0p branch from 3de3b36 to 93f9956 Compare May 10, 2021 09:05

vkucera mentioned this pull request May 12, 2021

PWGHF: implement event selection in track-index skim creator #6016

Merged

chiarazampolli changed the title ~~PWGHF: First version of skimming for Lc --> K0s+p~~ PWGHF: Implementation of Lc --> K0s+p May 17, 2021

vkucera approved these changes May 17, 2021

View reviewed changes

iarsene approved these changes May 17, 2021

View reviewed changes

iarsene merged commit 43ef15b into AliceO2Group:dev May 17, 2021

ginnocen pushed a commit to ginnocen/AliceO2 that referenced this pull request May 26, 2021

Revert "PWGHF: Implementation of Lc --> K0s+p (AliceO2Group#5257)"

0c53889

This reverts commit 43ef15b. ODOD On branch xicc_newgood

vkucera added a commit to vkucera/AliceO2 that referenced this pull request May 26, 2021

Revert "PWGHF: Implementation of Lc --> K0s+p (AliceO2Group#5257)"

a537995

This reverts commit 43ef15b.

aalkin added a commit to aalkin/AliceO2 that referenced this pull request Jun 4, 2021

Revert "PWGHF: Implementation of Lc --> K0s+p (AliceO2Group#5257)"

363d774

This reverts commit 43ef15b.

chiarazampolli deleted the LcV0p branch May 16, 2022 07:55

Search code, repositories, users, issues, pull requests...

Comments

Conversation

chiarazampolli commented Jan 21, 2021

Uh oh!

chiarazampolli commented Jan 22, 2021

Uh oh!

chiarazampolli commented Jan 23, 2021

Uh oh!

chiarazampolli commented Feb 12, 2021

Uh oh!

chiarazampolli commented Feb 18, 2021

Uh oh!

chiarazampolli commented Feb 19, 2021

Uh oh!

chiarazampolli commented Feb 19, 2021

Uh oh!

chiarazampolli commented Feb 19, 2021

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chiarazampolli commented Feb 23, 2021

Uh oh!

peressounko commented Feb 23, 2021

Uh oh!

chiarazampolli commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktf May 8, 2021

Choose a reason for hiding this comment

Uh oh!

vkucera May 8, 2021

Choose a reason for hiding this comment

Uh oh!

chiarazampolli May 10, 2021

Choose a reason for hiding this comment

Uh oh!

ddobrigk commented May 17, 2021

Uh oh!

chiarazampolli commented May 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

9 participants

chiarazampolli commented May 6, 2021 •

edited

Loading