Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

[O2-1977][CMake](fix) Filter out macros in build directory if any#5241

Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aphecetche:o2-1977aphecetche/AliceO2:o2-1977Copy head branch name to clipboard
Jan 20, 2021
Merged

[O2-1977][CMake](fix) Filter out macros in build directory if any#5241
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aphecetche:o2-1977aphecetche/AliceO2:o2-1977Copy head branch name to clipboard

Conversation

@aphecetche
Copy link
Collaborator

In the case where the build directory is created under the source one, the o2_get_list_of_macros was picking some macros from the build directory, which then the o2_report_non_tested_macros reported as missing.

@aphecetche aphecetche requested a review from a team as a code owner January 20, 2021 17:11
@ktf ktf self-requested a review January 20, 2021 18:27
@ktf ktf merged commit 6c5522b into AliceO2Group:dev Jan 20, 2021
@aphecetche aphecetche deleted the o2-1977 branch January 20, 2021 21:08
@ktf
Copy link
Member

ktf commented Feb 5, 2021

Apparently this is again an issue. See https://alice.its.cern.ch/jira/browse/O2-1896. Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.