Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DPL: fix parsing of inputspec metadata #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Oct 22, 2020
Merged

DPL: fix parsing of inputspec metadata #4660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 2 Framework/Core/src/WorkflowSerializationHelpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ struct WorkflowImporter : public rapidjson::BaseReaderHandler<rapidjson::UTF8<>,
outputHasSubSpec = false;
} else if (in(State::IN_OPTIONS)) {
push(State::IN_OPTION);
} else if (in(State::IN_INPUT_OPTIONS)) {
push(State::IN_OPTION);
} else if (in(State::IN_WORKFLOW_OPTIONS)) {
push(State::IN_OPTION);
} else if (in(State::IN_METADATA)) {
Expand Down
54 changes: 29 additions & 25 deletions 54 Framework/Core/test/test_WorkflowSerialization.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,35 @@ using namespace o2::framework;
BOOST_AUTO_TEST_CASE(TestVerifyWorkflow)
{
using namespace o2::framework;
WorkflowSpec w0{
DataProcessorSpec{"A",
{InputSpec{"foo", "A", "COLLISIONCONTEXT", 1, Lifetime::Condition, {ConfigParamSpec{"aUrl", VariantType::String, "foo/bar", {"A InputSpec option"}}}}},
{OutputSpec{{"bar"}, "C", "D", 2, Lifetime::Timeframe}},
AlgorithmSpec{[](ProcessingContext& ctx) {}},
{ConfigParamSpec{"aInt", VariantType::Int, 0, {"An Int"}},
ConfigParamSpec{"aFloat", VariantType::Float, 1.3, {"A Float"}},
ConfigParamSpec{"aBool", VariantType::Bool, true, {"A Bool"}},
ConfigParamSpec{"aString", VariantType::String, "some string", {"A String"}}}},
DataProcessorSpec{"B",
{InputSpec{"foo", "C", "D"}},
{OutputSpec{{"bar1"}, "E", "F", 0},
OutputSpec{{"bar2"}, "E", "F", 1}},
AlgorithmSpec{[](ProcessingContext& ctx) {}},
{}},
DataProcessorSpec{"C",
{},
{OutputSpec{{"bar"}, "G", "H"}},
AlgorithmSpec{[](ProcessingContext& ctx) {}},
{}},
DataProcessorSpec{"D",
{InputSpec{"foo", {"C", "D"}}},
{OutputSpec{{"bar"}, {"I", "L"}}},
AlgorithmSpec{[](ProcessingContext& ctx) {}},
{}}};
WorkflowSpec w0{ //
DataProcessorSpec{"A", //
{InputSpec{"foo", "A", "COLLISIONCONTEXT", 1, Lifetime::Condition, {
ConfigParamSpec{"aUrl", VariantType::String, "foo/bar", {"A InputSpec option"}}, //
ConfigParamSpec{"bUrl", VariantType::String, "foo/foo", {"Another InputSpec option"}}, //
}}}, //
{OutputSpec{{"bar"}, "C", "D", 2, Lifetime::Timeframe}}, //
AlgorithmSpec{[](ProcessingContext& ctx) {}}, //
{ //
ConfigParamSpec{"aInt", VariantType::Int, 0, {"An Int"}}, //
ConfigParamSpec{"aFloat", VariantType::Float, 1.3, {"A Float"}}, //
ConfigParamSpec{"aBool", VariantType::Bool, true, {"A Bool"}}, //
ConfigParamSpec{"aString", VariantType::String, "some string", {"A String"}}}}, // //
DataProcessorSpec{"B", //
{InputSpec{"foo", "C", "D"}}, //
{ //
OutputSpec{{"bar1"}, "E", "F", 0}, //
OutputSpec{{"bar2"}, "E", "F", 1}}, //
AlgorithmSpec{[](ProcessingContext& ctx) {}}, //
{}}, //
DataProcessorSpec{"C", {}, //
{ //
OutputSpec{{"bar"}, "G", "H"}}, //
AlgorithmSpec{[](ProcessingContext& ctx) {}}, //
{}}, //
DataProcessorSpec{"D", {InputSpec{"foo", {"C", "D"}}}, //
{OutputSpec{{"bar"}, {"I", "L"}}}, //
AlgorithmSpec{[](ProcessingContext& ctx) {}}, //
{}}}; //

std::vector<DataProcessorInfo> metadataOut{
{"A", "test_Framework_test_SerializationWorkflow", {"foo"}, {ConfigParamSpec{"aBool", VariantType::Bool, true, {"A Bool"}}}},
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.