CCDB: helper functions to handle Etag and multiple locations#2446
Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Oct 2, 2019
Merged
CCDB: helper functions to handle Etag and multiple locations#2446ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
Member
Author
|
These should allow DPL to fully work for CCDB reading, including ETag support and multiple (possibly storage backed) locations. |
Member
Author
|
Of course they can also be used to add ETag / multiple location support to the rest of the API. |
Barthelemy
requested changes
Sep 26, 2019
Collaborator
Barthelemy
left a comment
There was a problem hiding this comment.
Ok for me if you fix the formatting and the warning.
Member
Author
|
I fixed the warning (albeit one could claim that passing nullptr to a C API is actually wrong). The clang-format seems to have unrelated issues? It looks like it cannot do |
Member
Author
|
@MichaelLettrich did you fix the other macOS instances? |
Barthelemy
approved these changes
Oct 2, 2019
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Oct 23, 2019
carlos-soncco
pushed a commit
to carlos-soncco/AliceO2
that referenced
this pull request
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.