TRD MC Labels O2-847#2420
Merged
sawenzel merged 3 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Sep 30, 2019
jolopezl:trd-mclabels-O2-847Copy head branch name to clipboard
Merged
TRD MC Labels O2-847#2420sawenzel merged 3 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom jolopezl:trd-mclabels-O2-847Copy head branch name to clipboard
sawenzel merged 3 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
jolopezl:trd-mclabels-O2-847Copy head branch name to clipboard
Conversation
Contributor
Author
|
@tdietel, @bazinski, @sawenzel your comments are welcome. If you think this implementation requires a more detailed discussion we can continue the discussion in JIRA: https://alice.its.cern.ch/jira/browse/O2-847. |
Contributor
|
+1 |
Contributor
|
I have approve the PR. I still think we should go back to clean up the code once we have the basic simulation chain running, but I think this should not the interfaces we are defining at the moment. |
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Oct 23, 2019
* TRD MC Labels O2-847
carlos-soncco
pushed a commit
to carlos-soncco/AliceO2
that referenced
this pull request
Oct 28, 2019
* TRD MC Labels O2-847
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels are implemented for the TRD. This PR proposes using one label per hit, each label contains the usual MC label info + if the hit generated a digit or not and how many digits. In parallel, each digit now contains a short that corresponds to the label index to track down multiple digits originated from the same hit.
To keep the label index during the processing of hits an augmented arrayadc is used temporarily. Here, the last array value contains the label index (as an extra time bin, not used for an adc value, but for the label index). The ArrayADC sent in the digit container remains the same, and the label index is new member in the digit class too.
https://alice.its.cern.ch/jira/browse/O2-847.