Fixing overlaps in Pipe volumes description#1865
Merged
sawenzel merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Apr 9, 2019
Merged
Fixing overlaps in Pipe volumes description#1865sawenzel merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
sawenzel merged 2 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
Contributor
Author
|
Dear @sawenzel I created a PR for fixing the Pipe overlaps as you asked me. Please let me know if they are ok or if more is needed. Thanks. Cheers |
Collaborator
|
Great. I confirm that the overlaps are gone. Thanks for explaining your approach as well. |
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Apr 15, 2023
* Changes in filterPP and VarManager to allow using of just a minimal set of PID info * Removed the not needed Collisions table subscription from the barrel track and fwd track selection tasks. The process function was adapted. * clang fixes --------- Co-authored-by: iarsene <ionut.cristian.arsene@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A list of overlaps in the Pipe volume description was solved. See JIRA ticket https://alice.its.cern.ch/jira/browse/O2-599 for more details.