Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Fix: protection for sectorID overflow in CookerTracker#1855

Merged
shahor02 merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
shahor02:fix_CookTrSectorshahor02/AliceO2:fix_CookTrSectorCopy head branch name to clipboard
Apr 5, 2019
Merged

Fix: protection for sectorID overflow in CookerTracker#1855
shahor02 merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
shahor02:fix_CookTrSectorshahor02/AliceO2:fix_CookTrSectorCopy head branch name to clipboard

Conversation

@shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Apr 5, 2019

@iouribelikov @mpuccio : this fixes the crash in reconstruction (cluster phi happened to be exactly 2pi).

Yura, note that the CookedTracks is prone to crash in multi-thread mode, since the TGeometry used for material budget query is not thread-safe (navigator changes its state). With 8 threads I get:

#6  TObject::TestBit (f=32768, this=<optimized out>) at /home/shahoian/alice/sw/BUILD/f58b77b61af7bc34412ed1a39b4a5bd4a0b1a428/ROOT/include/TObject.h:172
#7  TGeoNode::IsOffset (this=<optimized out>) at /home/shahoian/alice/sw/BUILD/f58b77b61af7bc34412ed1a39b4a5bd4a0b1a428/ROOT/include/TGeoNode.h:100
...
#17 0x00007f383709b885 in o2::ITS::CookedTracker::makeBackPropParam (this=this
entry=0x7fffba178820, track=...) at /home/shahoian/alice/sw/SOURCES/O2/1.0.0/0/Detectors/ITSMFT/ITS/reconstruction/src/CookedTracker.cxx:600
#18 0x00007f383709ba1e in o2::ITS::CookedTracker::makeBackPropParam (this=this
entry=0x7fffba178820, seeds=std::vector of length 1, capacity 62 = {...}) at /home/shahoian/alice/sw/SOURCES/O2/1.0.0/0/Detectors/ITSMFT/ITS/reconstruction/src/CookedTracker.cxx:579
#19 0x00007f383709fb9c in o2::ITS::CookedTracker::trackInThread (...

Cheers,
Ruben

@iouribelikov
Copy link
Collaborator

iouribelikov commented Apr 5, 2019

@shahor02 Thank you for the fix, Ruben. I think we can merge it straight-away.

Yes, I know that TGeo navigation is not thread-safe. Unfortunately.
To run the CookedTracker in several threads, we need to comment out the back propagation of tracks.
Hopefully, we will not need to do so once the parametrized material budget becomes available.

@shahor02 shahor02 merged commit 217737a into AliceO2Group:dev Apr 5, 2019
@shahor02 shahor02 deleted the fix_CookTrSector branch April 5, 2019 14:01
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Apr 15, 2023
@mfaggin
DPG: add collision numContrib in the derived data. (AliceO2Group#1855)
b5b62c3 
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shahor02 @iouribelikov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.