separate T0 and V0 directory, V0 geometry and hits#1818
separate T0 and V0 directory, V0 geometry and hits#1818AllaMaevskaya wants to merge 12 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
shahor02
left a comment
There was a problem hiding this comment.
Hi @AllaMaevskaya , please see a few comments below.
There was a problem hiding this comment.
please leave the ACO last, just reassign T0=11, V0=12, FIT=13 and ACO=14
There was a problem hiding this comment.
And propagate the same to names
There was a problem hiding this comment.
do you nee o2::fit namespace declaration here? Below you use explicitly o2::fit::Digit.
There was a problem hiding this comment.
I would remove the macros relying on the FairRunAna chain. The DPL digitizer-workflow should be used.
There was a problem hiding this comment.
To be sure: what is the reason to have common V0,T0 digits (under the fit namespace) and separate RecPoints?
There was a problem hiding this comment.
in the HitType.h the HitType is defined in the o2::namespace, as well as in many places below.
There was a problem hiding this comment.
Above the V0 derives its own Hit class directly from the BasicXYZEHit. If this class is for T0 only, why is it in the common dir.?
87f44e2 to
f95e36f
Compare
No description provided.