change-new-cone#1662
Conversation
|
I going to review this part of the MFT code |
|
@frmanso : Thanks. |
fixed errors
|
I changed pointer names according "Details" e.g. Variable 's_box_mb0' is assigned a value that is never used." |
modifying name fra_front_Shape_1
Correction in the names assigned on the boolean part.
names fixed
excluding names pointer which are not used
|
@carlos-soncco : Can you please fix the clang-format problems? @frmanso : Please give your review. |
fixed according the clang-format.
removed an unnecessary parts
Fixing 1 according Codacy/PR
Fixing 2 according Codacy/PR
Fixing 3 according Codacy/PR
changing name of some variables
changing names of some variables 2
fixing point name 1v
|
Hello, It's still need work before to approve |
changing 1 volume name
changing 2 volume name
Removing the point name to use volume name in the boolean operations
removing point names 2
removing unnecessary lines
removing unnecessary comments
modified according clang
removing some point name
|
Hello, the code submitted by Carlos (half cone of MFT) is frozen since quite 2 months because of fairRoot error (see below). It doesn't see to be related to its code, what could be the problem here? /mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/GCC-Toolchain/v7.3.0-alice1-4/bin/../lib/gcc/x86_64-unknown-linux-gnu/7.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lBaseVGM |
|
Don't worry about this test. It's not mandatory. I was expecting to get a word / approval from @frmanso . I can merge thereafter. |
|
Hello, |
new version of the halfcone