Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

TRD hits update (O2-453)#1520

Merged
sawenzel merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
jolopezl:devCopy head branch name to clipboard
Dec 3, 2018
Merged

TRD hits update (O2-453)#1520
sawenzel merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
jolopezl:devCopy head branch name to clipboard

Conversation

@jolopezl
Copy link
Contributor

[WIP] (O2-453). Improving the Hits creation. Now the behaviour of ProcessHits() is closer to what was done in AliRoot. It still needs to include simulation of transition radiation.

Detectors/TRD/simulation/include/TRDSimulation/Detector.h Outdated Show resolved Hide resolved
@sawenzel
Copy link
Collaborator

sawenzel commented Dec 3, 2018

Can you still fix the formatting? See the proposed changes under the https://travis-ci.org/AliceO2Group/AliceO2/jobs/461874434 link.

Locally, you can fix the formatting by saying (in your case) git-clang-format HEAD^^^. Please see the main README.md for further instructions.

@jolopezl
Copy link
Contributor Author

jolopezl commented Dec 3, 2018

Hi @sawenzel,
I have fixed the formatting and now the test are all passing. As for what is requested by the o2checkcode I think we could still fixed it for this PR but I am not sure if this is what is desired by the original developer of that part of the code:

/mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/build_o2checkcode_o2/0/Detectors/TRD/base/include/TRDBase/TRDGeometry.h:33:11: error: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
/mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/build_o2checkcode_o2/0/Detectors/TRD/base/include/TRDBase/TRDGeometry.h:45:16: error: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]

Cheers,
Jorge

@sawenzel
Copy link
Collaborator

sawenzel commented Dec 3, 2018

@jolopezl : Thanks. I will merge it as is. Cool to have the first real TRD contribution.
Concerning the rest: Yes we should stick to the more modern C++11 guidelines which say that virtual is implicit with override. We can make a separate pass over all TRD and fix those problems all at once.

@sawenzel sawenzel changed the title [WIP] TRD hits update (O2-453) TRD hits update (O2-453) Dec 3, 2018
@sawenzel sawenzel merged commit 6df99a8 into AliceO2Group:dev Dec 3, 2018
mikesas pushed a commit to mikesas/AliceO2 that referenced this pull request Dec 13, 2022
…nctions, add cut (AliceO2Group#1520)

* PWGDQ/EM: change naming of PairCandidateType: kJpsiToEE -> kDecayToEE

* PWGDQ: change name in tableReader.cxx for pairType configurables to DecayToEE

* PWGDQ: add configurable for mixing depth

* PWGDQ:  HistogramsLibrary.h: rearrange pair histogram groups

* PWGDQ/EM: apply changes to tableReader in order to use configurables to add histograms in output.

* PWGDQ: cutLibray, add TPCnCls cut to TightGlobalTrack cut group

* PWGDQ: fix clang-formatting in dqEfficiency.cxx task

* PWGDQ/EM: fix MegaLinter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.